New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Ember to specify jQuery version #6741

Merged
merged 1 commit into from Apr 20, 2016

Conversation

Projects
None yet
2 participants
@acburdine
Member

acburdine commented Apr 19, 2016

replaces #6717

  • drops explicit jquery version dependency
  • fix slight acceptance test bug

@kevinansfield I'm surprised this specific change triggered this test bug, but I updated it to make a bit more sense.

allow ember to specify jQuery version
- fix slight acceptance test bug
@kevinansfield

This comment has been minimized.

Show comment
Hide comment
@kevinansfield

kevinansfield Apr 20, 2016

Contributor

@acburdine: I think the change was needed due to jquery/jquery#2227 - it was fixed/changed in jQuery 2.2 which would be why we're seeing different behaviour in the test

Contributor

kevinansfield commented Apr 20, 2016

@acburdine: I think the change was needed due to jquery/jquery#2227 - it was fixed/changed in jQuery 2.2 which would be why we're seeing different behaviour in the test

@kevinansfield kevinansfield merged commit f8f4d35 into TryGhost:master Apr 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinansfield kevinansfield deleted the acburdine:drop-jquery branch Apr 20, 2016

@acburdine acburdine restored the acburdine:drop-jquery branch Apr 28, 2016

@acburdine acburdine deleted the acburdine:drop-jquery branch Apr 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment