New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade knex version #7195

Merged
merged 1 commit into from Aug 11, 2016

Conversation

Projects
None yet
2 participants
@acburdine
Member

acburdine commented Aug 10, 2016

  • add useNullAsDefault flag to sqlite test config to fix breaking
    sqlite builds
  • fixes npm install issue with lodash dependency

The useNullAsDefault flag needs to exist because of our current test setup. Initially we were going to wait to upgrade knex until we could re-think the test setup, but because the 0.10 version of knex causes issues with a lodash dependency, it became necessary to upgrade knex, and to re-look at the test setup at somepoint in the future.

deps: knex@0.11.10
- add `useNullAsDefault` flag to sqlite test config to fix breaking
  sqlite builds
- fixes npm install issue with lodash dependency

@acburdine acburdine referenced this pull request Aug 10, 2016

Closed

Refactor test fixture utilities #7196

0 of 1 task complete

@ErisDS ErisDS merged commit cd4fb88 into TryGhost:master Aug 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

chris-brown added a commit to chris-brown/Ghost that referenced this pull request Aug 14, 2016

deps: knex@0.11.10 (TryGhost#7195)
- add `useNullAsDefault` flag to sqlite test config to fix breaking
  sqlite builds
- fixes npm install issue with lodash dependency

mixonic added a commit to mixonic/Ghost that referenced this pull request Oct 28, 2016

deps: knex@0.11.10 (TryGhost#7195)
- add `useNullAsDefault` flag to sqlite test config to fix breaking
  sqlite builds
- fixes npm install issue with lodash dependency

madfrog2047 added a commit to madfrog2047/Ghost that referenced this pull request Nov 20, 2016

deps: knex@0.11.10 (TryGhost#7195)
- add `useNullAsDefault` flag to sqlite test config to fix breaking
  sqlite builds
- fixes npm install issue with lodash dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment