New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃拕 Misc Cleanup #7479

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
2 participants
@ErisDS
Member

ErisDS commented Oct 3, 2016

This PR has 4 different commits, which can all be squashed into 1 if merging (e.g. combine the final 3 commits as list items on the first commit message)

The first commit removes two pieces of unused code which were hanging around in places I was looking at refactoring. The other 3 commits all update the internal apps, to be more consistent. There's much to do here, but I wanted to just move a few things out of my way and not go toooooo far down the app rabbit hole.

馃拕 Misc cleanup in middleware, helpers & apps
no issue

- unsued code:
  - there are no public assets anymore, might need to use this instead of shared in future, but for now lets remove it to reduce confusion
  - the `input password` box was incorrectly registered as an admin helper, thinking that was needed in order to render the default template. This isn't needed.
- apps:
  - small structure & comment update to amp app
  - moving input_password helper into private blogging app
  - refactor helpers in subscribers app

@ErisDS ErisDS added this to the 1.0.0-alpha.4 milestone Oct 4, 2016

@kirrg001 kirrg001 merged commit 7dba7b5 into TryGhost:master Oct 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

mixonic added a commit to mixonic/Ghost that referenced this pull request Oct 28, 2016

馃拕 Misc cleanup in middleware, helpers & apps (TryGhost#7479)
no issue

- unsued code:
  - there are no public assets anymore, might need to use this instead of shared in future, but for now lets remove it to reduce confusion
  - the `input password` box was incorrectly registered as an admin helper, thinking that was needed in order to render the default template. This isn't needed.
- apps:
  - small structure & comment update to amp app
  - moving input_password helper into private blogging app
  - refactor helpers in subscribers app

madfrog2047 added a commit to madfrog2047/Ghost that referenced this pull request Nov 20, 2016

馃拕 Misc cleanup in middleware, helpers & apps (TryGhost#7479)
no issue

- unsued code:
  - there are no public assets anymore, might need to use this instead of shared in future, but for now lets remove it to reduce confusion
  - the `input password` box was incorrectly registered as an admin helper, thinking that was needed in order to render the default template. This isn't needed.
- apps:
  - small structure & comment update to amp app
  - moving input_password helper into private blogging app
  - refactor helpers in subscribers app

@ErisDS ErisDS deleted the ErisDS:cleanup branch Mar 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment