Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
🔥 remove implementation of validate themes #7490
I just did this fast tidy up PR, took me 2mins.
@ErisDS When people copying their theme manual into the content folder, should we create another PR which validates these themes via
There are some things that need changing in how gscan is structured, so that we definitely can treat fatal errors differently to warnings.
Adding (installing) a theme, should probably only check that what's being installed IS a theme (which will get easier with the new package.json requirements).
I think there will eventually be some sort of interface that shows themes, along with if there's an update and if it's safe to activate. And/or theme activation may need an extra check for fatal errors.
I think once the CLI is in use, the manual copy into content folder use-case should fall into edge-case-land. We'll possibly leave it unchecked, and if users run into problems, add checks back later.
All of this should come a lot clearer when I've made some more progress on #7491.
For now... this, definitely this!