New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帹 use nullable(false) for knex schema builder #7511

Merged
merged 1 commit into from Oct 7, 2016

Conversation

Projects
None yet
2 participants
@kirrg001
Contributor

kirrg001 commented Oct 6, 2016

refs #7470

We have some random errors when running tests.

One of them is:

RangeError: Maximum call stack size exceeded
    at ColumnBuilder.(anonymous function) [as notNullable] (/home/travis/build/TryGhost/Ghost/node_modules/knex/lib/schema/columnbuilder.js:48:47)

I looked at the implementation of knex and they do:
if (method === 'notNullable') return this.nullable(false);

At this line, node get's stuck and calls this function over and over again until stack error occurs.

Quick fix: let's not use notNullable and instead use this.nullable(false) directly to avoid using this code.

@tgriesser might be interesting for you

@kirrg001

This comment has been minimized.

Show comment
Hide comment
@kirrg001

kirrg001 Oct 6, 2016

Contributor

I ran Travis 4 times, no errors. So maybe this PR helps? 馃尞

Contributor

kirrg001 commented Oct 6, 2016

I ran Travis 4 times, no errors. So maybe this PR helps? 馃尞

@ErisDS ErisDS merged commit f9561ee into TryGhost:master Oct 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

mixonic added a commit to mixonic/Ghost that referenced this pull request Oct 28, 2016

madfrog2047 added a commit to madfrog2047/Ghost that referenced this pull request Nov 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment