New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Move internal tags out of labs #7519

Merged
merged 1 commit into from Oct 10, 2016

Conversation

Projects
None yet
2 participants
@ErisDS
Member

ErisDS commented Oct 7, 2016

It would have been more ideal had I written explicit tests for the new visibility filter util, I realise, however I just wanted to get this working and submitted ready for alpha.4.

Will look at adding more tests later πŸŽ‰

TryGhost/Ghost-Admin#315 removes the actual check box & client-side logic

closes #6165

  • internal tags has been in labs for a couple of months, we've fixed some bugs & are ready to ship
  • removes all code that tests for the labs flag
  • also refactors the various usage of the visibility filter into a single util
  • all the tests still pass!!!
  • this marks #6165 as closed because I think the remaining UI tasks will be handled as part of a larger piece of work
✨ Move internal tags out of labs
closes #6165

- internal tags has been in labs for a couple of months, we've fixed some bugs & are ready to ship
- removes all code that tests for the labs flag
- also refactors the various usage of the visibility filter into a single util
- all the tests still pass!!!
- this marks #6165 as closed because I think the remaining UI tasks will be handled as part of a larger piece of work

@ErisDS ErisDS added this to the 1.0.0-alpha.4 milestone Oct 7, 2016

@kevinansfield

This comment has been minimized.

Show comment
Hide comment
@kevinansfield

kevinansfield Oct 10, 2016

Contributor

πŸ‘ LTGM, tested alongside the client PR and everything is working as expected πŸ˜„

Contributor

kevinansfield commented Oct 10, 2016

πŸ‘ LTGM, tested alongside the client PR and everything is working as expected πŸ˜„

@kevinansfield kevinansfield merged commit 63094d3 into TryGhost:master Oct 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinansfield kevinansfield deleted the ErisDS:internal-tag-labs-end branch Oct 10, 2016

mixonic added a commit to mixonic/Ghost that referenced this pull request Oct 28, 2016

✨ Move internal tags out of labs (TryGhost#7519)
closes TryGhost#6165

- internal tags has been in labs for a couple of months, we've fixed some bugs & are ready to ship
- removes all code that tests for the labs flag
- also refactors the various usage of the visibility filter into a single util
- all the tests still pass!!!
- this marks TryGhost#6165 as closed because I think the remaining UI tasks will be handled as part of a larger piece of work

madfrog2047 added a commit to madfrog2047/Ghost that referenced this pull request Nov 20, 2016

✨ Move internal tags out of labs (TryGhost#7519)
closes TryGhost#6165

- internal tags has been in labs for a couple of months, we've fixed some bugs & are ready to ship
- removes all code that tests for the labs flag
- also refactors the various usage of the visibility filter into a single util
- all the tests still pass!!!
- this marks TryGhost#6165 as closed because I think the remaining UI tasks will be handled as part of a larger piece of work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment