New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 logging: always print body of standalone error #7535

Merged
merged 1 commit into from Oct 11, 2016

Conversation

Projects
None yet
2 participants
@kirrg001
Contributor

kirrg001 commented Oct 10, 2016

On current master the body of standalone errors (logging.error({err: err}) are not displayed.
This PR will fix it.

The mode can be actually seen as http-mode for now.

I've added a little expectation test for the current Pretty Streamer to avoid the problem we have right now on master.

I've added more case comments and tried to tidy up this file a little little bit.

@kirrg001 kirrg001 added this to the 1.0.0-alpha.5 milestone Oct 10, 2016

馃悰 logging: always print body of standalone error
- we can see the logging mode as HTTP mode
- standalone logging should still log everything
- tidy up the PrettyStreamer a little big and add current expectation tests

@ErisDS ErisDS merged commit 0227efb into TryGhost:master Oct 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

mixonic added a commit to mixonic/Ghost that referenced this pull request Oct 28, 2016

馃悰 logging: always print body of standalone error (TryGhost#7535)
- we can see the logging mode as HTTP mode
- standalone logging should still log everything
- tidy up the PrettyStreamer a little big and add current expectation tests

madfrog2047 added a commit to madfrog2047/Ghost that referenced this pull request Nov 20, 2016

馃悰 logging: always print body of standalone error (TryGhost#7535)
- we can see the logging mode as HTTP mode
- standalone logging should still log everything
- tidy up the PrettyStreamer a little big and add current expectation tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment