Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimised how we execute server start/stop announcement #9815

Merged
merged 1 commit into from Aug 22, 2018

Conversation

Projects
None yet
1 participant
@kirrg001
Copy link
Contributor

kirrg001 commented Aug 22, 2018

closes #9802

  • we have to trigger both functions within Ghost core, otherwise people who are using Ghost as NPM module have to call these functions

  • this is internal logic

  • plus: this logic is also conditional, because of our internal maintenance flag

  • make it backwards compatible in case you call announceServerStart or announceServerStopped twice

  • test with NPM

  • test with CLI

@kirrg001 kirrg001 force-pushed the kirrg001:optimise-announce-start-stop branch Aug 22, 2018

Optimised how we execute server start/stop announcement
closes #9802

- we have to trigger both functions within Ghost core, otherwise people who are using Ghost as NPM module have to call these functions
- this is internal logic
- plus: this logic is also conditional, because of our internal maintenance flag
- make it backwards compatible in case you call announceServerStart or announceServerStopped twice

@kirrg001 kirrg001 force-pushed the kirrg001:optimise-announce-start-stop branch to f7e467c Aug 22, 2018

@kirrg001 kirrg001 changed the title [WIP] Optimised how we execute server start/stop announcement Optimised how we execute server start/stop announcement Aug 22, 2018

@kirrg001 kirrg001 merged commit 57a8bf2 into TryGhost:master Aug 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.