Refactored hardcoded v0.1 url tests to test all supported versions #9945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#9866 - used in unit tests to compare url created based on version
kirrg001
approved these changes
Oct 4, 2018
rishabhgrg
commented
Oct 4, 2018
|
|
||
| urlService.utils | ||
| .urlFor('api', {version: apiVersion, versionType: 'content'}, true) | ||
| .should.eql(`https://something.de${testUtils.API.getApiPath({version: apiVersion, versionType: 'content'})}`); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rishabhgrg
commented
Oct 4, 2018
| return `${baseAPIPath}v0.1/`; | ||
| } | ||
| } | ||
|
|
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
…s with new test util refs TryGhost#9866 - Updated all hardcoded v0.1 tests strings to use dynamic string from util method - Updated hardcoded v0.1 tests using regex match to use string equal with new util method
rishabhgrg
force-pushed
the
hardcoded-unittest-refactor
branch
from
5be9452
to
3804bf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #9866