Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add icon, ghost_head, and ghost_foot to data-stub file #18
Because the publication icon and the code injections are not populated by default for new Ghost instances, they are populated as
This is a known issue with GraphQL and being tracked for this repository here: TryGhost/gatsby-source-ghost#2
Due to this issue we created a data-stub file which needs to be imported before you connect the starter with your own Ghost installation.
This data-stub file needs to be amended to insert an icon (preferably
Whereas this change is pretty easy to do, it needs to be discussed and thought through, what data we want to inject and how to prevent overwriting existing one.
Once, the data-stub file is extended, we need to include those three properties in the
changed the title
Add `icon`, `ghost_head`, and `ghost_foot` to `data-stub.json` file
Jan 11, 2019
The main issue I see here is that the chance of someone having a custom icon || codeinjection already in place is very high. Adding those values to the data-stub file would cause it to overwrite their custom data which is not a nice solution.
One - very simple - solution could just be to write instructions in our README and explain that those fields need to be populated manually by the user.
Depending on the outcome of #20 the usage of