New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom helpers in env variable #91

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@benaubin
Copy link

benaubin commented Nov 17, 2017

This allows users to create custom apps that specify templates and allow them through ENV variables. This makes it hard to activate, but possible for developers (so only the people who should be using custom helpers use custom helpers).

Allow custom helpers in env variable
This allows users to create custom apps that specify templates and allow them through ENV variables. This makes it hard to activate, but possible for developers (so only the people who should be using custom helpers use custom helpers).
@ertrzyiks

This comment has been minimized.

Copy link

ertrzyiks commented Nov 17, 2017

Great! That would unblock me from migrating to ghost 1.x. This or an option like

I understand the risk, activate theme anyway

@benaubin

This comment has been minimized.

Copy link

benaubin commented Nov 17, 2017

Yeah, this was just a quick & easy fix. I would prefer a understand the risks prompt, but, In the meantime, this works. By the way, if this is blocking, you can monkey patch in current/node_modules/gscan/lib/spec.js.

@ErisDS

This comment has been minimized.

Copy link
Member

ErisDS commented Nov 17, 2017

I fully understand the problem here and why a way to do this is useful, however, I'm not 100% on the approach to a solution in this PR. I need to think about this a little bit from the perspective of what are apps likely to look like when they finally happen, aaaaand how will they interact with gscan. The end goal being to figure out if there's a obvious future-proof path here.

Let me have a think and come back to you. Ultimately, custom helpers are going to be possible, just need to figure out how.

@benaubin

This comment has been minimized.

Copy link

benaubin commented Nov 17, 2017

Cool! I totally agree! The goal of this PR is mainly just a way to give developers a temporary solution - not to create a future-proof one. The nice thing about ENV variables is that they can be accessed from any part of the app, so this solution is something that can be future proof. It also allows implementations of gscan that aren't running with apps to support custom helpers (for example, marketplaces), which allows use cases that don't run alongside ghost.

@ErisDS ErisDS force-pushed the TryGhost:master branch from 6527c14 to 22a0f54 Mar 16, 2018

@kirrg001

This comment has been minimized.

Copy link
Contributor

kirrg001 commented Jun 25, 2018

Sorry for late response. I'll close this pull request, because apps are tracked on our internal board and we would like to come up with a full solution to this problem. I hope you can understand our decision.

If you would like to suggest a new helper, which might be useful for many developers, let us know in our forum. We want to hear about use cases and are open to expand the core helpers.

@kirrg001 kirrg001 closed this Jun 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment