Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sqlite3 from 3.34.0 to 3.36.0 #1476

Merged
merged 1 commit into from Oct 8, 2021
Merged

Conversation

Glowin
Copy link
Contributor

@Glowin Glowin commented Jul 3, 2021

https://www.sqlite.org/releaselog/3_36_0.html

3.36.0 big feature: support RETURNING

@Glowin
Copy link
Contributor Author

Glowin commented Jul 5, 2021

@kewde @inukshuk Please review this PR, thanks.

kylosus added a commit to kylosus/Euphemia that referenced this pull request Jul 5, 2021
@Glowin
Copy link
Contributor Author

Glowin commented Jul 6, 2021

@kewde @nickrum @inukshuk Any update for this PR?

@Glowin
Copy link
Contributor Author

Glowin commented Jul 8, 2021

@kewde @nickrum @inukshuk Any update for this PR?

@inukshuk
Copy link
Contributor

inukshuk commented Jul 8, 2021

@Glowin I'm all for updating the bundled SQLite, however I'm not a maintainer, so I can't help expedite the process. I'm fairly certain that pinging the devs every other day is not helpful.

As a quick workaround, you can always build the module against the system's SQLite or you can patch it with your own version (that's what I've been doing myself).

@Glowin
Copy link
Contributor Author

Glowin commented Jul 8, 2021

@inukshuk

  1. I had patch it for my own version.
  2. I think it's the admin's responsibility to keep the repository up to date, as this repository gets 439,216 installs a week on npm.
  3. Thanks for your reply and sorry for interrupt.

@bodaso
Copy link

bodaso commented Jul 28, 2021

also ALTER TABLE DROP COLUMN feature in 3.35.0

@freben
Copy link

freben commented Oct 2, 2021

@kewde i'll join the ones gently pinging for this - it would be very valuable to get this merged

@kewde
Copy link
Collaborator

kewde commented Oct 8, 2021

Website:

sqlite-autoconf-3360000.tar.gz(2.84 MiB) |   | C source code as an amalgamation.  Also includes a "configure" script   and TEA makefiles for the TCL Interface.(sha3: fdc699685a20284cb72efe3e3ddfac58e94d8ffd5b229a8235d49265aa776678)

FIle validated:

user@dev:~/Downloads$ openssl dgst -sha3-256 sqlite-autoconf-3360000.tar.gz 
SHA3-256(sqlite-autoconf-3360000.tar.gz)= fdc699685a20284cb72efe3e3ddfac58e94d8ffd5b229a8235d49265aa776678

SHA3-256 OK

@kewde kewde merged commit bc5d794 into TryGhost:master Oct 8, 2021
@johan13
Copy link

johan13 commented Oct 21, 2021

Now that this is merged, any chance we can get a new tag and upload to npmjs?

@kibertoad
Copy link

@kewde Is there any ETA on the next release?

@adrienboulle
Copy link

@kewde any chance this is released any time soon ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants