New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tasks to return streams #11

Merged
merged 1 commit into from Jan 16, 2014

Conversation

Projects
None yet
2 participants
@contra

contra commented Jan 15, 2014

You need to return the streams otherwise the task system treats the task function as a simple synchronous task. I noticed your benchmarks seemed a little too good to be true

fix tasks to return streams
You need to return the streams otherwise the task system treats the task function as a simple synchronous task. I noticed your benchmarks seemed a little too good to be true
@mrmartineau

This comment has been minimized.

Show comment
Hide comment
@mrmartineau

mrmartineau Jan 16, 2014

Thanks @contra, I am obviously new to gulp and the idea of streams so your help is very welcome. I used Travis Maynard's blog post to create this one which is where the problem may have started. I will try the same again and let you know the differences.

Thanks

mrmartineau commented on 08d4c15 Jan 16, 2014

Thanks @contra, I am obviously new to gulp and the idea of streams so your help is very welcome. I used Travis Maynard's blog post to create this one which is where the problem may have started. I will try the same again and let you know the differences.

Thanks

mrmartineau added a commit that referenced this pull request Jan 16, 2014

Merge pull request #11 from Contra/patch-1
fix tasks to return streams

@mrmartineau mrmartineau merged commit c952a35 into TryKickoff:gulp Jan 16, 2014

@contra contra deleted the contra:patch-1 branch Jan 16, 2014

@contra

This comment has been minimized.

Show comment
Hide comment
@contra

contra Jan 16, 2014

Cool - thanks!

contra commented Jan 16, 2014

Cool - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment