Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avatar and image component enhancements #394

Closed
jahnli opened this issue Jul 5, 2021 · 0 comments · Fixed by #485
Closed

avatar and image component enhancements #394

jahnli opened this issue Jul 5, 2021 · 0 comments · Fixed by #485
Assignees
@Talljack
Labels
feature request New feature or request

Comments

@jahnli
Copy link
Collaborator

jahnli commented Jul 5, 2021

This function solves the problem (这个功能解决的问题)

component enhancements

Expected API (期望的 API)

1.Missing callback or placeholder for image load failure
2.Provides properties that fit the container, （fill / contain / cover / none / scale-down）
@jahnli jahnli changed the title avatar component enhancements avatar and image component enhancements Jul 5, 2021
@07akioni 07akioni added the feature request New feature or request label Jul 5, 2021
@Talljack Talljack self-assigned this Jul 8, 2021
@Talljack Talljack mentioned this issue Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Talljack Talljack

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Image and Avatar): add onError and objectFit props Talljack/naive-ui
3 participants
@07akioni @jahnli @Talljack