Skip to content

Conversation

@datejada
Copy link
Member

@datejada datejada commented Oct 7, 2024

Related issues

Closes #56

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

@datejada datejada requested a review from abelsiqueira October 7, 2024 09:47
@codecov
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f997beb) to head (c339fbd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          218       218           
=========================================
  Hits           218       218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datejada datejada merged commit 78a7561 into TulipaEnergy:main Oct 7, 2024
@datejada datejada deleted the 56-fix-compat-bounds-duckDB branch October 7, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Add compat bound for DuckDB_jll and DuckDB versions

2 participants