This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
Fix text sizing for onboarding flow #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfjarvis
approved these changes
Sep 2, 2021
msfjarvis
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear developer:
Hello! I am the creator of issue #504, and I have fixed the blocked welcome banner when open this app for the very first time. I would genuinely appreciate it if you could kindly revise my code and leave me some advice. Thank you so much for your precious time!
Here are the screenshots after my changes, and I did some tests on two different APIs:
Pixel 2 with API 29:
Pixel 2 with API 25:
Thanks again! Blessings on your day! :)