New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrome 62: icons are mislocated #126

Closed
felipem775 opened this Issue Oct 19, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@felipem775

felipem775 commented Oct 19, 2017

In the new Chrome version, 62, the icons in sidebar are mislocated some pixels down.

chrome61
chrome62

@Turbo87

This comment has been minimized.

Show comment
Hide comment
@Turbo87

Turbo87 Oct 19, 2017

Owner

Sounds like a bug in Chrome to me... 🤔

Owner

Turbo87 commented Oct 19, 2017

Sounds like a bug in Chrome to me... 🤔

@markhepburn

This comment has been minimized.

Show comment
Hide comment
@markhepburn

markhepburn Oct 23, 2017

Just came to report this -- you can "fix" it by removing the overflow:hidden rule, but that's presumably pretty fragile.

markhepburn commented Oct 23, 2017

Just came to report this -- you can "fix" it by removing the overflow:hidden rule, but that's presumably pretty fragile.

@markhepburn

This comment has been minimized.

Show comment
Hide comment

markhepburn commented Oct 23, 2017

@markhepburn

This comment has been minimized.

Show comment
Hide comment
@markhepburn

markhepburn Oct 23, 2017

Sorry for the noise, but from the above issue the following rule might be a more robust fix:

.sidebar-tabs > li, .sidebar-tabs > ul > li {
    list-style-type: none;
}

markhepburn commented Oct 23, 2017

Sorry for the noise, but from the above issue the following rule might be a more robust fix:

.sidebar-tabs > li, .sidebar-tabs > ul > li {
    list-style-type: none;
}
@Turbo87

This comment has been minimized.

Show comment
Hide comment
@Turbo87

Turbo87 Oct 25, 2017

Owner

Thanks for figuring this out @markhepburn! #127 should fix the issue until Chrome releases a fixed version.

Owner

Turbo87 commented Oct 25, 2017

Thanks for figuring this out @markhepburn! #127 should fix the issue until Chrome releases a fixed version.

@eric47905

This comment has been minimized.

Show comment
Hide comment
@eric47905

eric47905 Aug 18, 2018

I know this issue is old and already closed, but adding this in, just in case someone else has an issue like I did. This is in Chrome V68 and the current version of IOS Safari, same vertical alignment issue in both.

Opposite the icons displaying too far down, Mine were displaying all the way at the top of each 40px square. I fixed by adding some top padding to the .sidebar-tabs > li > a, .sidebar-tabs > ul > li > a { section.

.sidebar-tabs > li > a, .sidebar-tabs > ul > li > a { display: block; width: 100%; height: 100%; line-height: 40px; color: inherit; text-decoration: none; text-align: center; list-style-type: none; padding-top: 10; padding-right: 0; padding-left: 0; padding-bottom: 0; }

misalignment pic

eric47905 commented Aug 18, 2018

I know this issue is old and already closed, but adding this in, just in case someone else has an issue like I did. This is in Chrome V68 and the current version of IOS Safari, same vertical alignment issue in both.

Opposite the icons displaying too far down, Mine were displaying all the way at the top of each 40px square. I fixed by adding some top padding to the .sidebar-tabs > li > a, .sidebar-tabs > ul > li > a { section.

.sidebar-tabs > li > a, .sidebar-tabs > ul > li > a { display: block; width: 100%; height: 100%; line-height: 40px; color: inherit; text-decoration: none; text-align: center; list-style-type: none; padding-top: 10; padding-right: 0; padding-left: 0; padding-bottom: 0; }

misalignment pic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment