New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes v5.1 #1158

Merged
merged 2 commits into from Dec 7, 2017

Conversation

Projects
None yet
2 participants
@DenisCarriere
Member

DenisCarriere commented Dec 6, 2017

Release notes v5.1

@rowanwins @muziejus Anything to add to the release notes before I publish the release?

@DenisCarriere DenisCarriere added the docs label Dec 6, 2017

@DenisCarriere DenisCarriere added this to the 5.1.0 milestone Dec 6, 2017

@DenisCarriere DenisCarriere self-assigned this Dec 6, 2017

@muziejus

This comment has been minimized.

Show comment
Hide comment
@muziejus

muziejus Dec 6, 2017

Collaborator

I was thinking about maybe we should rename @turf/center-mean to @turf/center-weighted-mean and farm out its (unweighted) mean-finding to @turf/centroid?

Collaborator

muziejus commented Dec 6, 2017

I was thinking about maybe we should rename @turf/center-mean to @turf/center-weighted-mean and farm out its (unweighted) mean-finding to @turf/centroid?

Show outdated Hide outdated releases/5.1.0.md Outdated
Show outdated Hide outdated releases/5.1.0.md Outdated
@muziejus

This comment has been minimized.

Show comment
Hide comment
@muziejus

muziejus Dec 7, 2017

Collaborator

I'm putting together a pr rn for center-weighted-mean

Collaborator

muziejus commented Dec 7, 2017

I'm putting together a pr rn for center-weighted-mean

@muziejus

This comment has been minimized.

Show comment
Hide comment
@muziejus

muziejus Dec 7, 2017

Collaborator

my tests are failing because I don't know how to tell turf there's a new name for the module.

Collaborator

muziejus commented Dec 7, 2017

my tests are failing because I don't know how to tell turf there's a new name for the module.

@DenisCarriere

This comment has been minimized.

Show comment
Hide comment
@DenisCarriere

DenisCarriere Dec 7, 2017

Member

@muziejus I was thinking about maybe we should rename @turf/center-mean to @turf/center-weighted-mean

We can simply deprecate @turf/centroid in favor of @turf/center-mean since that would be the most "accurate" meaning for centroid.

Weighted or unweighted shouldn't be two modules, it should simply remain to be an option in @turf/center-mean.

Deprecating @turf/centroid would only display a message saying "next major release it will be removed", we've done this for a few modules already.

Member

DenisCarriere commented Dec 7, 2017

@muziejus I was thinking about maybe we should rename @turf/center-mean to @turf/center-weighted-mean

We can simply deprecate @turf/centroid in favor of @turf/center-mean since that would be the most "accurate" meaning for centroid.

Weighted or unweighted shouldn't be two modules, it should simply remain to be an option in @turf/center-mean.

Deprecating @turf/centroid would only display a message saying "next major release it will be removed", we've done this for a few modules already.

@muziejus

This comment has been minimized.

Show comment
Hide comment
@muziejus

muziejus Dec 7, 2017

Collaborator

@DenisCarriere cheers. Deprecating @turf/centroid sounds like the better solution.

Collaborator

muziejus commented Dec 7, 2017

@DenisCarriere cheers. Deprecating @turf/centroid sounds like the better solution.

@DenisCarriere DenisCarriere merged commit 1854656 into master Dec 7, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@DenisCarriere DenisCarriere deleted the release-v5.1 branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment