Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript declaration to @turf/clean-coords #1608

Merged

Conversation

@oliverroick
Copy link
Contributor

oliverroick commented Mar 5, 2019

Hi,

While working with @turf/clean-coords, I noticed that the package doesn't have a TypeScript declaration. This PR proposes a definition for the function cleanCoords.

The changes are pretty straightforward; I used a generic that must extend Geometry or Feature.

Let me know when you require any changes.


Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

Submitting a new TurfJS Module.

  • Overview description of proposed module.
  • Include JSDocs with a basic example.
  • Execute ./scripts/generate-readmes to create README.md.
  • Add yourself to contributors in package.json using "Full Name <@github Username>".
Copy link
Member

morganherlocker left a comment

Looks great 👍

@morganherlocker morganherlocker merged commit ebbdf83 into Turfjs:master Mar 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@morganherlocker

This comment has been minimized.

Copy link
Member

morganherlocker commented Mar 6, 2019

Thanks @oliverroick !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.