Skip to content

Conversation

@penelopeysm
Copy link
Member

Closes #1140, as discussed in today's meeting.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Benchmark Report

  • this PR's head: 574f0b4bd058fba793ccdab47a5137ccecaa1eff
  • base branch: 993cc5ba5d90cbc5be8cc60e190a5de05ef491b3

Computer Information

Julia Version 1.11.7
Commit f2b3dbda30a (2025-09-08 12:10 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

┌───────────────────────┬───────┬─────────────┬───────────────────┬────────┬─────────────────────────────────┬────────────────────────────┬─────────────────────────────────┐
│                       │       │             │                   │        │        t(eval) / t(ref)         │     t(grad) / t(eval)      │        t(grad) / t(ref)         │
│                       │       │             │                   │        │ ──────────┬───────────┬──────── │ ───────┬─────────┬──────── │ ──────────┬───────────┬──────── │
│                 Model │   Dim │  AD Backend │           VarInfo │ Linked │      base │   this PR │ speedup │   base │ this PR │ speedup │      base │   this PR │ speedup │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼───────────┼───────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│               Dynamic │    10 │    mooncake │             typed │   true │    367.18 │    361.60 │    1.02 │  11.01 │   10.99 │    1.00 │   4043.24 │   3973.16 │    1.02 │
│                   LDA │    12 │ reversediff │             typed │   true │   8374.88 │   3445.73 │    2.43 │   2.65 │    5.47 │    0.48 │  22155.88 │  18837.83 │    1.18 │
│   Loop univariate 10k │ 10000 │    mooncake │             typed │   true │ 107570.34 │ 111107.34 │    0.97 │   4.11 │    3.93 │    1.04 │ 441680.69 │ 437158.00 │    1.01 │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼───────────┼───────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│    Loop univariate 1k │  1000 │    mooncake │             typed │   true │   8135.68 │   9582.93 │    0.85 │   4.75 │    3.95 │    1.20 │  38680.52 │  37816.00 │    1.02 │
│      Multivariate 10k │ 10000 │    mooncake │             typed │   true │  33106.39 │  79731.98 │    0.42 │  10.05 │    5.55 │    1.81 │ 332869.36 │ 442461.79 │    0.75 │
│       Multivariate 1k │  1000 │    mooncake │             typed │   true │   8352.57 │   3543.77 │    2.36 │   4.15 │    9.56 │    0.43 │  34676.99 │  33872.09 │    1.02 │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼───────────┼───────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│ Simple assume observe │     1 │ forwarddiff │             typed │  false │      2.72 │      2.69 │    1.01 │   3.94 │    3.97 │    0.99 │     10.70 │     10.67 │    1.00 │
│           Smorgasbord │   201 │ forwarddiff │             typed │  false │   1218.29 │   1216.10 │    1.00 │ 123.49 │   63.26 │    1.95 │ 150444.87 │  76930.22 │    1.96 │
│           Smorgasbord │   201 │ forwarddiff │       simple_dict │   true │       err │       err │     err │    err │     err │     err │       err │       err │     err │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼───────────┼───────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│           Smorgasbord │   201 │ forwarddiff │ simple_namedtuple │   true │       err │       err │     err │    err │     err │     err │       err │       err │     err │
│           Smorgasbord │   201 │      enzyme │             typed │   true │   1706.17 │   1736.31 │    0.98 │   5.61 │    7.14 │    0.79 │   9569.12 │  12392.68 │    0.77 │
│           Smorgasbord │   201 │    mooncake │             typed │   true │   1727.61 │   1677.72 │    1.03 │   5.20 │    5.38 │    0.97 │   8978.72 │   9033.29 │    0.99 │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼───────────┼───────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│           Smorgasbord │   201 │ reversediff │             typed │   true │   1894.75 │   1687.21 │    1.12 │  78.62 │   89.35 │    0.88 │ 148955.90 │ 150745.35 │    0.99 │
│           Smorgasbord │   201 │ forwarddiff │      typed_vector │   true │   1691.14 │   1685.63 │    1.00 │  55.37 │   58.06 │    0.95 │  93646.57 │  97872.79 │    0.96 │
│           Smorgasbord │   201 │ forwarddiff │           untyped │   true │   1696.68 │   1688.79 │    1.00 │  56.70 │   57.60 │    0.98 │  96196.81 │  97281.80 │    0.99 │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼───────────┼───────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│           Smorgasbord │   201 │ forwarddiff │    untyped_vector │   true │   1673.74 │   1713.30 │    0.98 │  54.81 │   57.09 │    0.96 │  91730.23 │  97806.93 │    0.94 │
│              Submodel │     1 │    mooncake │             typed │   true │      7.43 │      7.39 │    1.01 │   5.04 │    5.53 │    0.91 │     37.44 │     40.87 │    0.92 │
└───────────────────────┴───────┴─────────────┴───────────────────┴────────┴───────────┴───────────┴─────────┴────────┴─────────┴─────────┴───────────┴───────────┴─────────┘

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.99%. Comparing base (993cc5b) to head (574f0b4).
⚠️ Report is 1 commits behind head on breaking.

Additional details and impacted files
@@            Coverage Diff            @@
##           breaking    #1161   +/-   ##
=========================================
  Coverage     79.99%   79.99%           
=========================================
  Files            41       41           
  Lines          3874     3874           
=========================================
  Hits           3099     3099           
  Misses          775      775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@penelopeysm penelopeysm merged commit 54ae7e3 into breaking Dec 1, 2025
21 checks passed
@penelopeysm penelopeysm deleted the py/lp-or-logjoint branch December 1, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants