-
Notifications
You must be signed in to change notification settings - Fork 37
Allow gradient on LDF to be called with e.g. views #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Benchmark Report
Computer InformationBenchmark Results |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 79.99% 80.01% +0.01%
==========================================
Files 41 41
Lines 3874 3877 +3
==========================================
+ Hits 3099 3102 +3
Misses 775 775 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhauru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me if tests pass.
I benchmarked locally and didn't find any performance regression on the normal Vector use case (since
convertis just a no-op).