Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to compute relative ESS #81

Merged
merged 4 commits into from May 4, 2023
Merged

Add option to compute relative ESS #81

merged 4 commits into from May 4, 2023

Conversation

sethaxen
Copy link
Member

Fixes #80 by adding a convenience keyword relative=false to ess and ess_rhat.

@sethaxen sethaxen requested a review from devmotion April 16, 2023 18:53
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2023

Pull Request Test Coverage Report for Build 4714877976

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 96.556%

Totals Coverage Status
Change from base Build 4399022657: 0.008%
Covered Lines: 813
Relevant Lines: 842

💛 - Coveralls

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f2aca2d) 96.54% compared to head (8d46fec) 96.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   96.54%   96.55%           
=======================================
  Files          10       10           
  Lines         840      842    +2     
=======================================
+ Hits          811      813    +2     
  Misses         29       29           
Impacted Files Coverage Δ
src/ess_rhat.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sethaxen sethaxen merged commit 5b3e960 into main May 4, 2023
10 of 11 checks passed
@sethaxen sethaxen deleted the ess_rel branch May 4, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add relative_efficiency?
2 participants