-
Notifications
You must be signed in to change notification settings - Fork 231
Adds predict method to make it easier to work with the predictive posterior
#1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
IMO we should definitely overload |
Codecov Report
@@ Coverage Diff @@
## master #1286 +/- ##
==========================================
+ Coverage 67.81% 68.29% +0.48%
==========================================
Files 25 25
Lines 1367 1391 +24
==========================================
+ Hits 927 950 +23
- Misses 440 441 +1
Continue to review full report at Codecov.
|
cpfiffer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No further comments from me! Looks solid as all get-out.
With this method you can now do:
One question: should this method be exported? I'm currently overloading
StatsBase.predictbecause Turing will often used together with StatsBase and so I figured overloading rather than defining our own is preferable to avoid warnings. This is also up for discussion; I'm fine either way.