Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping Overhaul #58

Merged
merged 4 commits into from May 13, 2019

Conversation

Projects
None yet
1 participant
@Turnerj
Copy link
Member

commented May 12, 2019

Started out working on commands for #57 but instead turned to fundamentally changing how mapping works.

Big difference is there is a central static EntityMapping class which manages the mapping processors and the entity definitions. This replaces the EntityMapper class which was always a little weird.

Big changes to indexing as well, most of the internal code is scraped and acts more like a normal mapping processor. Functionally though, indexes and compound indexes work as before.

With the changes, mapping no longer requires a MongoDbConnection instance - making it far easier to use in some tricky places in the code.

@codecov

This comment has been minimized.

Copy link

commented May 12, 2019

Codecov Report

Merging #58 into master will decrease coverage by 1.02%.
The diff coverage is 92.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   93.27%   92.24%   -1.03%     
==========================================
  Files          61       64       +3     
  Lines        2200     2218      +18     
==========================================
- Hits         2052     2046       -6     
- Misses        148      172      +24
Impacted Files Coverage Δ
.../MongoFramework/Attributes/CreatedDateAttribute.cs 100% <ø> (ø) ⬆️
src/MongoFramework/Attributes/IndexAttribute.cs 100% <ø> (ø) ⬆️
.../MongoFramework/Attributes/UpdatedDateAttribute.cs 66.66% <ø> (ø) ⬆️
src/MongoFramework/MongoDbUtility.cs 100% <ø> (ø)
...ngoFramework/Infrastructure/EntityChangeTracker.cs 100% <ø> (ø) ⬆️
...rk/Infrastructure/Internal/ReflectionExtensions.cs 60% <ø> (ø)
...frastructure/Diagnostics/NoOpDiagnosticListener.cs 33.33% <ø> (ø)
...re/DefinitionHelpers/UpdateDefinitionExtensions.cs 100% <ø> (ø) ⬆️
...rk/Infrastructure/Diagnostics/DiagnosticCommand.cs 100% <ø> (ø)
...ructure/Linq/Processors/EntityTrackingProcessor.cs 100% <ø> (ø) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27a84c9...2a0ea49. Read the comment docs.

@Turnerj Turnerj merged commit 35c5b5e into master May 13, 2019

2 of 4 checks passed

codecov/patch 92.45% of diff hit (target 93.27%)
Details
codecov/project 92.24% (-1.03%) compared to 27a84c9
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Turnerj Turnerj deleted the mapping-overhaul branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.