Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityWriter system overhaul to support commands #59

Merged
merged 6 commits into from May 13, 2019

Conversation

Projects
None yet
1 participant
@Turnerj
Copy link
Member

commented May 13, 2019

Adds command support as noted in #57

@Turnerj Turnerj added the enhancement label May 13, 2019

@codecov

This comment was marked as outdated.

Copy link

commented May 13, 2019

Codecov Report

Merging #59 into master will decrease coverage by 1.09%.
The diff coverage is 82.13%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #59     +/-   ##
=========================================
- Coverage   92.24%   91.14%   -1.1%     
=========================================
  Files          64       68      +4     
  Lines        2218     2338    +120     
=========================================
+ Hits         2046     2131     +85     
- Misses        172      207     +35
Impacted Files Coverage Δ
...ramework/Infrastructure/Mutation/EntityMutation.cs 60.6% <0%> (-39.4%) ⬇️
...Infrastructure/Commands/RemoveEntityByIdCommand.cs 100% <100%> (ø)
src/MongoFramework/MongoDbSet.cs 79.78% <100%> (-3.4%) ⬇️
.../MongoFramework/Infrastructure/EntityCollection.cs 95.78% <100%> (ø) ⬆️
...rastructure/Commands/EntityDefinitionExtensions.cs 100% <100%> (ø)
...ructure/Linq/Processors/EntityTrackingProcessor.cs 100% <100%> (ø) ⬆️
src/MongoFramework/MongoDbBucketSet.cs 94.8% <100%> (-0.26%) ⬇️
...goFramework/Infrastructure/EntityCommandBuilder.cs 100% <100%> (ø)
...ork/Infrastructure/Commands/UpdateEntityCommand.cs 100% <100%> (+100%) ⬆️
...ork/Infrastructure/Commands/RemoveEntityCommand.cs 100% <100%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c5b5e...9143d77. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #59 into master will increase coverage by 0.37%.
The diff coverage is 91.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   92.24%   92.62%   +0.37%     
==========================================
  Files          64       68       +4     
  Lines        2218     2304      +86     
==========================================
+ Hits         2046     2134      +88     
+ Misses        172      170       -2
Impacted Files Coverage Δ
...Infrastructure/Commands/RemoveEntityByIdCommand.cs 100% <100%> (ø)
.../MongoFramework/Infrastructure/EntityCollection.cs 95.78% <100%> (ø) ⬆️
...rastructure/Commands/EntityDefinitionExtensions.cs 100% <100%> (ø)
...ructure/Linq/Processors/EntityTrackingProcessor.cs 100% <100%> (ø) ⬆️
src/MongoFramework/MongoDbSet.cs 79.78% <100%> (-3.4%) ⬇️
...goFramework/Infrastructure/EntityCommandBuilder.cs 100% <100%> (ø)
...ork/Infrastructure/Commands/UpdateEntityCommand.cs 100% <100%> (+100%) ⬆️
...ure/Mutation/Mutators/NavigationPropertyMutator.cs 100% <100%> (ø) ⬆️
...ork/Infrastructure/Commands/RemoveEntityCommand.cs 100% <100%> (ø)
src/MongoFramework/MongoDbBucketSet.cs 94.8% <100%> (-0.26%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c5b5e...866e58c. Read the comment docs.

@Turnerj Turnerj merged commit 282f843 into master May 13, 2019

3 of 4 checks passed

codecov/patch 91.74% of diff hit (target 92.24%)
Details
WIP Ready for review
Details
codecov/project 92.62% (+0.37%) compared to 35c5b5e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Turnerj Turnerj deleted the entity-command-writing branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.