Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET Core 3 #62

Merged
merged 4 commits into from May 18, 2019

Conversation

Projects
None yet
1 participant
@Turnerj
Copy link
Member

commented May 18, 2019

Changes for TestBase relate to reflection changes for readonly statics, see: dotnet/coreclr#21268

Turnerj added some commits May 18, 2019

Add constants and update tests to support .NET Core 3
Changes for TestBase relate to reflection changes for readonly statics, see: dotnet/coreclr#21268
@codecov

This comment has been minimized.

Copy link

commented May 18, 2019

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files          68       68           
  Lines        2306     2306           
=======================================
  Hits         2136     2136           
  Misses        170      170
Impacted Files Coverage Δ
src/MongoFramework/MongoDbConnection.cs 89.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d1ade8...60ee678. Read the comment docs.

Bump MongoDB driver version
This should address failing .NET Core 3 tests

@Turnerj Turnerj referenced this pull request May 18, 2019

Closed

WIP: .Net Core 3 #44

@Turnerj

This comment has been minimized.

Copy link
Member Author

commented May 18, 2019

It seems like the issues with #61 are the same types of issues seen in mongodb/mongo-csharp-driver#372 - bumping MongoDB driver to v2.8.1 resolves TypeInitializationException in MongoDB.Bson.Serialization.BsonClassMap.

@Turnerj Turnerj changed the title WIP: Support .NET Core 3 Support .NET Core 3 May 18, 2019

@Turnerj Turnerj merged commit d2e0385 into master May 18, 2019

4 checks passed

WIP Ready for review
Details
codecov/patch Coverage not affected when comparing 8d1ade8...60ee678
Details
codecov/project 92.62% remains the same compared to 8d1ade8
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Turnerj Turnerj deleted the dotnet-core-3-support branch May 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.