Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod::Usage in xls2csv #23

Closed
wants to merge 1 commit into from
Closed

Conversation

@happy-barney
Copy link

@happy-barney happy-barney commented Mar 28, 2018

No description provided.

@happy-barney
Copy link
Author

@happy-barney happy-barney commented Mar 28, 2018

Example on one file. If you'll like it, I'll adapt other examples as well.

@Tux
Copy link
Owner

@Tux Tux commented Mar 28, 2018

I applied it locally to see what happens. Hmm.

  1. The pod should be at the end of the file IMHO (after __END__)
  2. I want the default --help to be as short as it was. This is way to verbose for -?/--help
  3. I'm (very) open to using this as a --man/--manual/--info option
  4. The text part of -o is missing a closing paren
  5. CSVFILE should be CSV-file and XLSFILE should be XLS-file

Acceptable compromise?

@happy-barney
Copy link
Author

@happy-barney happy-barney commented Mar 29, 2018

I have no problem with that

@Tux
Copy link
Owner

@Tux Tux commented Mar 29, 2018

Then go for it. If I am happy, I'll merge.
Any other suggestions?

Branislav Zahradník
@happy-barney happy-barney force-pushed the happy-barney:with-pod-usage branch from 8e8de4d to e7af0bd Mar 29, 2018
@happy-barney
Copy link
Author

@happy-barney happy-barney commented Apr 21, 2018

@Tux are you happy with last changes? or still something to improve?

@Tux
Copy link
Owner

@Tux Tux commented Aug 29, 2018

Sorry for the delay. I've done da8b031 using your suggested help as base. I found too many things in pod2usage for the basic usage annoying to also use it for --help.
Thanks for your interest and help and feedback.
I will release soon.

@Tux Tux closed this Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants