New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy files if they cannot be hardlinked #6

Merged
merged 1 commit into from Aug 7, 2015

Conversation

Projects
None yet
2 participants
@bentglasstube
Contributor

bentglasstube commented Aug 6, 2015

In some cases, hard links are not available. The xlsgrep and xlscat
programs are actually the same script and Makefile.PL links them as
such. Since both items are installed by default in a non-interactive
installation, if the hard link fails, building the module will also
fail. If for whatever reason we are not able to hard link the files, we
should try just copying them as a backup.

I initially thought using a symbolic link would be a good backup choice
but I am not aware of a portable way to do that.

Copy files if they cannot be hardlinked
In some cases, hard links are not available.  The `xlsgrep` and `xlscat`
programs are actually the same script and Makefile.PL links them as
such.  Since both items are installed by default in a non-interactive
installation, if the hard link fails, building the module will also
fail.  If for whatever reason we are not able to hard link the files, we
should try just copying them as a backup.

I initially thought using a symbolic link would be a good backup choice
but I am not aware of a portable way to do that.
@bentglasstube

This comment has been minimized.

Show comment
Hide comment
@bentglasstube

bentglasstube Aug 6, 2015

Contributor

Hopefully a fix for #4

Contributor

bentglasstube commented Aug 6, 2015

Hopefully a fix for #4

Tux added a commit that referenced this pull request Aug 7, 2015

Merge pull request #6 from bentglasstube/fix-hard-link
Copy files if they cannot be hardlinked

@Tux Tux merged commit 814b965 into Tux:master Aug 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Tux

This comment has been minimized.

Show comment
Hide comment
@Tux

Tux Aug 7, 2015

thanks! merged. for this time.

next time I only merge if the style matches. I'll make a note in a new CONTRIBUTING file

Tux commented on 5f21216 Aug 7, 2015

thanks! merged. for this time.

next time I only merge if the style matches. I'll make a note in a new CONTRIBUTING file

This comment has been minimized.

Show comment
Hide comment
@bentglasstube

bentglasstube Aug 7, 2015

Owner
Owner

bentglasstube replied Aug 7, 2015

This comment has been minimized.

Show comment
Hide comment
@Tux

Tux Aug 7, 2015

I just added https://github.com/Tux/Spreadsheet-Read/blob/master/CONTRIBUTING.md
Thanks for making me notice, as I will now add that to all my github projects

Tux replied Aug 7, 2015

I just added https://github.com/Tux/Spreadsheet-Read/blob/master/CONTRIBUTING.md
Thanks for making me notice, as I will now add that to all my github projects

This comment has been minimized.

Show comment
Hide comment
@bentglasstube

bentglasstube Aug 7, 2015

Owner
Owner

bentglasstube replied Aug 7, 2015

This comment has been minimized.

Show comment
Hide comment
@Tux

Tux replied Aug 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment