TvdW / tor Public

Decoding tests will follow later

It works... but I think it needs more code still

The tor_cert_get_checkable_sig function uses the signing key included in
the certificate (if available) when a separate public key is not given.

When the signature is valid, the tor_cert_checksig function copies the
public key from the checkable structure to the public key field of the
certificate signing key.

In situations where the separate public key is not given but the
certificate includes a signing key, the source and destination pointers
in the copy operation are equal and invoke undefined behavior.

Undefined behaviour is avoided by ensuring both pointers are different.

Closes ticket 17724. Bug fix on ade5005 and 5e9f238,
not in any released version of Tor. Patch by "teor".

Change the function names & comments to make the copying explicit.

…7638.

Bugfix on a tor version before the refactoring in git commit
cea1225 (23 Sep 2009). Patch by "teor".

Nobody likes a stack overflow, even in unit tests.

Closes 17699; but not in any released tor.

(crypto_rand is no longer allowed to fail.)

Closes bug 17686; bug not in any released tor.  (No backport, since
the tortls tests aren't in 0.2.7)

Check that crypto_rand doesn't return all zeroes, identical values,
or incrementing values (OpenSSL's rand_predictable feature).

… checked