Feature ignore glob #15

Closed
wants to merge 18 commits into
from

Conversation

Projects
None yet
3 participants
@kbl

kbl commented Dec 14, 2011

New feature - supporting ignore globs mentioned in issue #8.

@copiousfreetime

This comment has been minimized.

Show comment Hide comment
@copiousfreetime

copiousfreetime Jan 2, 2012

Collaborator

I believe some of my recent comments no longer make this pull request cleanly apply. I was working on Issue #16 and found a few more bugs that I had introduce.

@TwP you want to merge this after @kbl does a rebase?

Collaborator

copiousfreetime commented Jan 2, 2012

I believe some of my recent comments no longer make this pull request cleanly apply. I was working on Issue #16 and found a few more bugs that I had introduce.

@TwP you want to merge this after @kbl does a rebase?

@TwP

This comment has been minimized.

Show comment Hide comment
@TwP

TwP Feb 27, 2012

Owner

It has been a while, but did you already implement this feature Jeremy with your refactorings?

Owner

TwP commented Feb 27, 2012

It has been a while, but did you already implement this feature Jeremy with your refactorings?

@copiousfreetime

This comment has been minimized.

Show comment Hide comment
@copiousfreetime

copiousfreetime Feb 27, 2012

Collaborator

No, I didn't implement ignore.

Collaborator

copiousfreetime commented Feb 27, 2012

No, I didn't implement ignore.

@kbl

This comment has been minimized.

Show comment Hide comment
@kbl

kbl Mar 8, 2012

Should I rebase this code?

kbl commented Mar 8, 2012

Should I rebase this code?

@copiousfreetime

This comment has been minimized.

Show comment Hide comment
@copiousfreetime

copiousfreetime Mar 9, 2012

Collaborator

yes, I would say do a rebase.

Collaborator

copiousfreetime commented Mar 9, 2012

yes, I would say do a rebase.

@copiousfreetime

This comment has been minimized.

Show comment Hide comment
@copiousfreetime

copiousfreetime Mar 9, 2012

Collaborator

Actually, It will probably be easier to just pull out the ignore globs functionality and skip all the test rearrangement

Collaborator

copiousfreetime commented Mar 9, 2012

Actually, It will probably be easier to just pull out the ignore globs functionality and skip all the test rearrangement

@copiousfreetime

This comment has been minimized.

Show comment Hide comment
@copiousfreetime

copiousfreetime Feb 8, 2013

Collaborator

Closing this pull request as it is stale. A new pull requests for this feature should be submitted that is rebased against master.

Collaborator

copiousfreetime commented Feb 8, 2013

Closing this pull request as it is stale. A new pull requests for this feature should be submitted that is rebased against master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment