-
-
Notifications
You must be signed in to change notification settings - Fork 492
Add certificate expiration support #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 84.67% 84.82% +0.14%
==========================================
Files 14 14
Lines 509 514 +5
==========================================
+ Hits 431 436 +5
Misses 56 56
Partials 22 22
Continue to review full report at Codecov.
|
02ee2cb
to
27c8c55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and thank you for the contribution @Exagone313!
I'll merge this into master, run a few tests on my end this feature will be included in the next release.
The pleasure is mine, it's been a while I needed a tool like yours, I just missed this feature. |
@Exagone313 I was just about to release it in v1.6.0, but the more I think about it, the more I think it'd be silly to leave it in milliseconds. Does anybody realistically care about millisecond precision for certificate expiration? I'm thinking that it may be better to just have it in days instead (e.g. What do you think @Exagone313 @r3vit? |
@TwinProduction I think it makes more sense to keep all durations in the same "unit" and rather replace strings such as |
Released in v1.6.0 |
Fixes #28