Skip to content

Add certificate expiration support - #37

Merged
TwiN merged 4 commits into
TwiN:masterfrom
Exagone313:certificate-expiration
Nov 15, 2020
Merged

Add certificate expiration support#37
TwiN merged 4 commits into
TwiN:masterfrom
Exagone313:certificate-expiration

Conversation

@Exagone313

@Exagone313 Exagone313 commented Nov 15, 2020

Copy link
Copy Markdown
Contributor

Fixes #28

@codecov-io

codecov-io commented Nov 15, 2020

Copy link
Copy Markdown

Codecov Report

Merging #37 (27c8c55) into master (f273ee4) will increase coverage by 0.14%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   84.67%   84.82%   +0.14%     
==========================================
  Files          14       14              
  Lines         509      514       +5     
==========================================
+ Hits          431      436       +5     
  Misses         56       56              
  Partials       22       22              
Impacted Files Coverage Δ
core/condition.go 87.62% <75.00%> (+0.26%) ⬆️
core/service.go 68.29% <100.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d184786...27c8c55. Read the comment docs.

@Exagone313 Exagone313 changed the title Add certificate expiration support (fixes #28) Add certificate expiration support Nov 15, 2020
Comment thread core/types.go Outdated
Comment thread core/condition_test.go Outdated
@Exagone313
Exagone313 force-pushed the certificate-expiration branch from 02ee2cb to 27c8c55 Compare November 15, 2020 17:48
@Exagone313
Exagone313 requested a review from TwiN November 15, 2020 17:53

@TwiN TwiN left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and thank you for the contribution @Exagone313!

I'll merge this into master, run a few tests on my end this feature will be included in the next release.

@TwiN
TwiN merged commit d1f24db into TwiN:master Nov 15, 2020
@Exagone313

Copy link
Copy Markdown
Contributor Author

The pleasure is mine, it's been a while I needed a tool like yours, I just missed this feature.

@TwiN

TwiN commented Nov 15, 2020

Copy link
Copy Markdown
Owner

@Exagone313 I was just about to release it in v1.6.0, but the more I think about it, the more I think it'd be silly to leave it in milliseconds.

Does anybody realistically care about millisecond precision for certificate expiration?

I'm thinking that it may be better to just have it in days instead (e.g. [CERTIFICATE_EXPIRATION] > 7 where 7 is the number of days)

What do you think @Exagone313 @r3vit?

@Exagone313
Exagone313 deleted the certificate-expiration branch November 16, 2020 08:27
@Exagone313

Copy link
Copy Markdown
Contributor Author

@TwinProduction I think it makes more sense to keep all durations in the same "unit" and rather replace strings such as 7d.

@TwiN

TwiN commented Nov 17, 2020

Copy link
Copy Markdown
Owner

Released in v1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add placeholder to resolve time left until certificate expiration

3 participants