Fix 32-bit bitmap support #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works like a charm :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alrighty, after learning way too much about the BMP format, here's a fix for my previous PR (sorry!) which supports the custom byte ordering format. For simplicity it only supports the four bitmasks which move full bytes to full bytes (see
getBitfield). I think this feature is also possible with 24-bit bitmaps (they'd show up as(24, 1, 3)) but I'm gonna leave that to someone who actually needs it.I also added the
(32, 1, 0)image I actually needed to decode so that both formats are tested. All the bitmap tests convert correctly with thetoPngexecutable :) And I removed the-- TODO: put 3 for RGBAcomment since the0it puts out now is correct.