Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Using Kalendae from a dialog that is shown from a scrolled page #15

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

ruckus commented Mar 19, 2012

I am using Bootstrap and using the Modal dialog widget. Inside my widget I have a Kalendae object.

If I display a modal dialog box and the page is scrolled down than Kalendae does not properly calculate the top position because it doesnt factor in the amount the page is scrolled down.

This pull request tweaks the getPosition method and adds the scroll top to the final coordinates.

calculate and add the scrollTop position. this fixes an issue where w…
…e instantiate the calendar in a modal dialog (e.g. a Boostrap modal dialog) that is scrolled down the page)
Owner

Twipped commented Mar 20, 2012

Outside of a position:fixed element (which I'm assuming your popup window is), this change results in the popup appearing nowhere near the target input. I'll do some experimentation to see if I can address the issue you're having, but I'm afraid this pull request isn't usable in its current state. Just try it with the current index.html example file and you'll see what I mean.

@Twipped Twipped closed this Mar 20, 2012

ruckus commented Mar 20, 2012

Gotcha. I've made a simple page to replicate this issue.

https://github.com/ruckus/kalendae-modal-scroll-test

The README contains some basic instructions on how to toggle correct / incorrect behavior.

Please let me know if there is anything I can do.

Bumped into this as well, would be great to have a fix!

ruckus commented Mar 26, 2012

Looks like this was fixed in 20255ad

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment