Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several additions: endDate view option, 'draw-end' event, removeAllSelected() method, caption changes, & 'k-blackout' class #161

Merged
merged 15 commits into from Jun 30, 2016

Conversation

@coreyzev
Copy link
Contributor

coreyzev commented Oct 24, 2015

First off, this has as lot of changes (though mostly very simple) in one request. I did not test extensively. But I have been working in Chrome & IE9. So far, so good.

Feel free to take bits and pieces of this.

I made sure to break it up into commits for each feature. So you can see each one on its own. (Aside from the last commit, which was a bit of an afterthought).

In more detail:

  • fixed variables - f17ab6b - for some reason both variables for disable next were disableNext sans the declaration. So I added Month and Year respectively
  • Month Caption adjustments - d973408 - I changed the title span to a div, and placed the month and year in their own divs so they can be styled on their own if needed. (e.g. http://i.imgur.com/y0yK34I.png )
  • removeAllSelected() - 8ac3047 - I needed this in my own code, and I figured I'd be doing it more than once, so I just wrote a method and added it in.
  • 'draw-end' event - 120b579 - I needed to do more jQuery styling after a draw had finished and I had no way of knowing without relying on a combination of "view-changed" and "change", and even then there were still gaps.
  • 'k-blackout' class - 35f21cc - because sometimes you want to style blacked out dates differently than inactive dates
  • endDate option - 2955464 - I had a situation where I need to limit not just the direction the calendar starts in, but also where it ends. And so I added this to control that. Following all the patterns set out by previous day selection options.
  • The last 3 commits are just updating the readme, fixing the css for the title, and fixing a bug #2697 that I realized due to moment

thanks for making such a great, agnostic, datepicker! I'm really enjoying using it. And modifying it.

@coreyzev

This comment has been minimized.

Copy link
Contributor Author

coreyzev commented Jun 27, 2016

I am working with Kalendae again for the first time since last year, and I will need some of these changes again.

Obviously I will need to fix the conflicts, but is there anything else in particular that kept you from either refusing or accepting this pull request?

Such as making a pull request for each new feature?

@Twipped

This comment has been minimized.

Copy link
Owner

Twipped commented Jun 28, 2016

I don't remember seeing this PR before, so I think I just somehow overlooked it. The changes look reasonable, if you can address the conflicts then I'll merge it.

@Twipped

This comment has been minimized.

Copy link
Owner

Twipped commented Jun 28, 2016

Since there's a lot of new features in this PR, could you also update the changelog with everything it adds, under the In Development heading.

@coreyzev coreyzev force-pushed the coreyzev:new-event-method-and-option branch 2 times, most recently from b3507f9 to d356978 Jun 29, 2016
@coreyzev

This comment has been minimized.

Copy link
Contributor Author

coreyzev commented Jun 29, 2016

Conflicts fixed, need to update the changelog

@coreyzev coreyzev force-pushed the coreyzev:new-event-method-and-option branch from 410e0bc to 06a6018 Jun 29, 2016
@coreyzev

This comment has been minimized.

Copy link
Contributor Author

coreyzev commented Jun 29, 2016

Okay. That was so much rebasing... but it's done. I apologize the builds are in there, but I think it might be too late to change?

Thanks!

@Twipped

This comment has been minimized.

Copy link
Owner

Twipped commented Jun 30, 2016

Rocking. Will try to wrap up a release this weekend.

@Twipped Twipped merged commit d8f27af into Twipped:dev Jun 30, 2016
@coreyzev

This comment has been minimized.

Copy link
Contributor Author

coreyzev commented Jun 30, 2016

I just realized I forgot to add the changelog the new class k-blackout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.