New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding email support #220

Merged
merged 1 commit into from Apr 24, 2016

Conversation

Projects
None yet
4 participants
@aYoussef
Contributor

aYoussef commented Sep 9, 2015

As per their documentation, Twitter started to include the user email on the verify request endpoint.
https://dev.twitter.com/rest/reference/get/account/verify_credentials
This PR includes a way for the library users to send parameters to the verify_credentials endpoint to request the user email

@tmbull

This comment has been minimized.

tmbull commented Nov 16, 2015

@yusuke Could you please look at this PR? We also would like to be able to retrieve user email addresses, and this seems like a simple solution. Thanks!

@firstthumb

This comment has been minimized.

firstthumb commented Jan 3, 2016

When are you planning to merge this PR?
And It looks like working.

@yusuke

This comment has been minimized.

Collaborator

yusuke commented Jan 23, 2016

Hi,

TwitterBaseImpl#fillInIDAndScreenName() and HttpParameter are not intended to be exposed in a public interface.
Maybe we can pass skip_status & include_email as true, and allow clients to set to false in twitter4j.properties.

@yusuke yusuke merged commit 39cd327 into Twitter4J:master Apr 24, 2016

takke pushed a commit to takke/Twitter4J that referenced this pull request Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment