Support extended tweets #247

takke · Sep 18, 2016

To support extended tweets, add configuration of "tweet_mode=extended" and some fixes.

Upcoming changes to Tweets | Twitter Developers

日本語はこちら↓

samruston · Sep 19, 2016

Any updates on this PR?

matthewbogner · Sep 20, 2016

matthewbogner reviewed Sep 20, 2016

View changes

matthewbogner · Sep 20, 2016

twitter4j-core/src/main/java/twitter4j/TwitterImpl.java

@@ -77,6 +77,9 @@
            if (conf.isIncludeExtAltTextEnabled()) {
                params.add(new HttpParameter("include_ext_alt_text", "true"));
            }
+            if (conf.isTweetModeExtended()) {
+                params.add(new HttpParameter("tweet_mode", "extended"));


I think an enum would be useful here to illustrate the allowed values of tweet_mode ("compat" and "extended")

I need you need to change the size of the params variable:

List params = new ArrayList(4);

matthewbogner · Sep 20, 2016

matthewbogner reviewed Sep 20, 2016

View changes

matthewbogner · Sep 20, 2016

twitter4j-core/src/main/java/twitter4j/conf/ConfigurationBase.java

@@ -73,6 +73,7 @@
    private boolean includeEntitiesEnabled = true;
    private boolean trimUserEnabled = false;
    private boolean includeExtAltTextEnabled = true;
+    private boolean tweetModeExtended = false;


I would favor this being a String or Enum value to accommodate any future usage of this tweet_mode parameter by Twitter with new values.

frangarcia · Sep 20, 2016

It would be nice to have this pull request merged when possible as Twitter has already started to roll out some changes to support more than 140 chars when using other entities like hashtags or urls https://dev.twitter.com/overview/api/upcoming-changes-to-tweets

frangarcia · Sep 21, 2016

frangarcia reviewed Sep 21, 2016

View changes

frangarcia · Sep 21, 2016

twitter4j-appengine/src/main/java/twitter4j/LazyStatus.java

@@ -81,6 +81,15 @@ public String getText() {
        return getTarget().getText();
    }

+    @Override


I don't think you need to add the Override annotation

frangarcia · Sep 21, 2016

frangarcia reviewed Sep 21, 2016

View changes

frangarcia · Sep 21, 2016

twitter4j-appengine/src/main/java/twitter4j/LazyStatus.java

+        return getTarget().getDisplayTextRangeStart();
+    }
+
+    @Override


I don't think you need to add the Override annotation

frangarcia · Sep 21, 2016

frangarcia reviewed Sep 21, 2016

View changes

frangarcia · Sep 21, 2016

twitter4j-core/src/main/java/twitter4j/Status.java

@@ -48,6 +48,10 @@
     */
    String getText();

+    int getDisplayTextRangeStart();


I would also add the javadoc part for those 2 methods

takke · Sep 28, 2016

MediaEntityをExtendedMediaEntity相当にする修正を行いました。

GIF動画や動画を含む140文字超ツイートをStreamingで取得した場合に、extended_tweet.entities.media に載る動画情報を取得できるようにするためです。

DMのGIF動画や動画についても同様で、#234 は不要になるのでクローズしました。

詳細は Twitter4JのExtendedMediaEntity廃止について - Qiita にまとめてあります。

YousefED · Sep 28, 2016

What's needed before supporting / merging this? I can help if necessary, Twitter already switched to extended tweets, so we'd need this ourselves sooner than later.

paulpach · Nov 10, 2016

What else is needed to merge this? it sucks having to maintain our own builds.

tjallingt · Nov 14, 2016

Hey, Just checking in on this pull request to mention how important it is to merge this soon as Twitter already heavily relies on extended_tweet's...
Any ETA for when this will be merged?

mrkumarawanish · Nov 15, 2016

When we can expect to have tweet_mode feature in twitter 4j library?

alfonsordm · Nov 22, 2016

alfonsordm approved these changes Nov 22, 2016

View changes

vickyst · Nov 25, 2016

Just wanted to add my voice to the requests for this - is there an ETA for this?

lmserrano · Dec 9, 2016

Also looking forward to have this soon. Any ETA yet? Is there any help needed?

yusuke · Jan 6, 2017

Hi, The pull request has been merged. And the latest build is available on the central repository as version 4.4.5. Best regards, Yusuke

…

On Dec 9, 2016, at 21:43, Luis Miguel Serrano ***@***.***> wrote: Also looking forward to have this soon. Any ETA yet? Is there any help needed? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

paulpach · Jan 6, 2017

there is no 4.4.5 version in maven central. The latest version is 4.0.6

frangarcia · Jan 6, 2017

I think @yusuke got confused with the version and he meant 4.0.5 https://mvnrepository.com/artifact/org.twitter4j/twitter4j-core/4.0.5

frangarcia · Jan 11, 2017

@yusuke can you please confirm which version of twitter4j has this pull request merged in? I was just checking 4.0.5 and it does not seem to have this pull request. If 4.0.5 does not have this pull request, is 4.0.6 a final/stable version? 4.0.6 definitely has this pull request merged in.

MattWilliams89 · Feb 15, 2017

Thanks for merging this, working well on 4.0.6 for me

takke added some commits Sep 17, 2016

Support "tweet_mode=extended"

f7e0e1c

Support full_text, display_text_range, and extended_tweet

Loading status checks…

2698452

no need to merge extended_entities on extended_tweet

Loading status checks…

2e25157

nonylene referenced this pull request Sep 27, 2016
Closed
twitter-extended #59

Move video_info to MediaEntity from ExtendedMediaEntity
(for extended_tweet.entities.media and entities on DMs)

Loading status checks…

0f37a6a

takke referenced this pull request Sep 28, 2016
Closed
support "video_info" for direct messages #234

takke referenced this pull request Sep 30, 2016
Merged
Remove ExtendedMediaEntity #250

fix IMPLICIT_PARAMS_STR

Loading status checks…

6b67635

takke referenced this pull request Oct 19, 2016
Closed
fix IMPLICIT_PARAMS_STR #1

yusuke merged commit d25b340 into Twitter4J:master Dec 24, 2016
1 check failed

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

takke pushed a commit to takke/Twitter4J that referenced this pull request Jul 23, 2018

Merge pull request Twitter4J#247 from takke/support_extended_tweets
Support extended tweets

0a86eea

takke deleted the takke:support_extended_tweets branch Oct 23, 2018

Twitter4J/Twitter4J

Join GitHub today

Support extended tweets #247

Conversation

takke commented Sep 18, 2016

takke added some commits Sep 17, 2016

This comment has been minimized.

samruston commented Sep 19, 2016

matthewbogner reviewed Sep 20, 2016 View changes

This comment has been minimized.

This comment has been minimized.

matthewbogner reviewed Sep 20, 2016 View changes

This comment has been minimized.

matthewbogner Sep 20, 2016 • edited

This comment has been minimized.

frangarcia commented Sep 20, 2016

frangarcia reviewed Sep 21, 2016 View changes

This comment has been minimized.

frangarcia reviewed Sep 21, 2016 View changes

This comment has been minimized.

frangarcia reviewed Sep 21, 2016 View changes

This comment has been minimized.

frangarcia Sep 21, 2016 • edited

nonylene referenced this pull request Sep 27, 2016

takke referenced this pull request Sep 28, 2016

This comment has been minimized.

takke commented Sep 28, 2016 • edited

This comment has been minimized.

YousefED commented Sep 28, 2016

takke referenced this pull request Sep 30, 2016

takke referenced this pull request Oct 19, 2016

This comment has been minimized.

paulpach commented Nov 10, 2016

This comment has been minimized.

tjallingt commented Nov 14, 2016

This comment has been minimized.

mrkumarawanish commented Nov 15, 2016 • edited

alfonsordm approved these changes Nov 22, 2016 View changes

This comment has been minimized.

vickyst commented Nov 25, 2016

This comment has been minimized.

lmserrano commented Dec 9, 2016

Hide details View details yusuke merged commit d25b340 into Twitter4J:master Dec 24, 2016 1 check failed

1 check failed

This comment has been minimized.

yusuke commented Jan 6, 2017

This comment has been minimized.

paulpach commented Jan 6, 2017

This comment has been minimized.

frangarcia commented Jan 6, 2017

This comment has been minimized.

frangarcia commented Jan 11, 2017 • edited

This comment has been minimized.

MattWilliams89 commented Feb 15, 2017

takke pushed a commit to takke/Twitter4J that referenced this pull request Jul 23, 2018

takke deleted the takke:support_extended_tweets branch Oct 23, 2018

matthewbogner reviewed Sep 20, 2016

View changes

matthewbogner reviewed Sep 20, 2016

View changes

matthewbogner Sep 20, 2016 •

edited

frangarcia reviewed Sep 21, 2016

View changes

frangarcia reviewed Sep 21, 2016

View changes

frangarcia reviewed Sep 21, 2016

View changes

frangarcia Sep 21, 2016 •

edited

takke commented Sep 28, 2016 •

edited

mrkumarawanish commented Nov 15, 2016 •

edited

alfonsordm approved these changes Nov 22, 2016

View changes

yusuke merged commit `d25b340` into Twitter4J:master Dec 24, 2016
1 check failed

frangarcia commented Jan 11, 2017 •

edited