Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the url shortener provider pluggable #25

Closed
sametmax opened this issue Jan 31, 2013 · 6 comments
Closed

Make the url shortener provider pluggable #25

sametmax opened this issue Jan 31, 2013 · 6 comments

Comments

@sametmax
Copy link
Contributor

Google url shortener has been mention has a better alternative with https hosted site. But is.id is a more neutral provider.

Been able to use both should be possible but setting it in the configuration file.

@sametmax
Copy link
Contributor Author

We got the code from Natim@28bff88 to make it work with google API.

I'd suggest:

make an settings such as :

URL_SHORTENER = {
"name": 'google',
'api key': 'bla'
}

make the python code print this as json in the HTML.
make the jscode setup the proper backup according to the name

For now we can just have google and is.gd. We can make Google's the default one, but we need to offer is.gd as an alternative (with warning regarding the https problem) because Google is becoming more and more a hot potatoes these days.

@v6
Copy link

v6 commented Jul 15, 2015

// , Maybe there could be some sort of failover mode?

Reminds me of #80.

@timss
Copy link

timss commented Dec 21, 2015

In the event that you're hosting 0bin yourself, having a native URL shortener on that domain would be preferably in certain scenarios. Maybe it could come in the form of an additional URL rewrite/route?

@sametmax
Copy link
Contributor Author

That would defeat the entire purpose or 0bin as the server would need to
hold the decryption key to redirect from the short url to the full url.

Le 21/12/2015 10:19, timss a écrit :

In the event that you're hosting 0bin yourself, having a native URL
shortener on that domain would be preferably in certain scenarios.
Maybe it could come in the form of an additional URL rewrite/route?


Reply to this email directly or view it on GitHub
#25 (comment).

@timss
Copy link

timss commented Dec 21, 2015

Good point, hadn't thought about that. Please excuse my short sightedness.

@ksamuel
Copy link
Collaborator

ksamuel commented Aug 12, 2020

The short url feature has been removed in V2, so I'm closing this.

@ksamuel ksamuel closed this as completed Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants