Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gRPC and Go plugins by default #811

Open
matiasinsaurralde opened this issue Jun 16, 2017 · 4 comments

Comments

Projects
None yet
6 participants
@matiasinsaurralde
Copy link
Member

commented Jun 16, 2017

Do you want to request a feature or report a bug?
Enhancement
What is the current behavior?
Currently if you want to support gRPC you need to use the "coprocess" and "grpc" build tags.
As I work on the plugins, I introduced a "go" build tag but I would like to get rid of it.

What is the expected behavior?
It would be much better if we support Go and gRPC plugins by default, as these don't require cgo at all.

Which versions of Tyk affected by this issue? Did this work in previous versions of Tyk?
All.

@mvdan

This comment has been minimized.

Copy link
Contributor

commented Jun 16, 2017

Sounds good. No reason to keep it hidden in a build tag.

@matiasinsaurralde matiasinsaurralde self-assigned this Jul 11, 2017

@buger buger added this to the Release 2.5 milestone Nov 23, 2017

@lonelycode lonelycode removed this from the Release 2.5 milestone Dec 4, 2017

@nickReyn nickReyn added this to the Release 2.6 milestone Jan 17, 2018

@lonelycode

This comment has been minimized.

Copy link
Member

commented Jan 31, 2018

Constraint on this should be gRPC for now, we still need a good way to build go plugins.

@matiasinsaurralde

This comment has been minimized.

Copy link
Member Author

commented Jan 31, 2018

It would be useful to have a gRPC-Go plugin tutorial for now, based on this request.

@buger

This comment has been minimized.

Copy link
Member

commented Feb 7, 2018

@matiasinsaurralde can you clarify a bit. From what I understand having tags that build things separately not that bad, main idea here is that we should ship this functionality in default binaries.

Can this task be solved purely by our packaging scripts, and just including "coprocess" tag in all our builds by default?

@ilijabojanovic ilijabojanovic modified the milestones: Release 2.6.1, Release 2.6.2 Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.