Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TD-918]: Sync releng templates. #4157

Merged
merged 6 commits into from Aug 3, 2022
Merged

[TD-918]: Sync releng templates. #4157

merged 6 commits into from Aug 3, 2022

Conversation

asutosh
Copy link
Contributor

@asutosh asutosh commented Jun 27, 2022

Update/Sync Releng templates for tyk

🤖 Beep, boop, this PR has been generated by automation on Mon Jun 27 06:30:40 UTC 2022

This PR updates the release engineering specific code in the tyk repo,
and has been generated because some releng code was changed, and
the corresponding templates were updated.

These changes will mostly be limited to the ci/ directory and .github directory.

If you think this was made by mistake, or if merging this might cause any instabilities,
please log a jira ticket in the TD project citing this PR.

@asutosh
Copy link
Contributor Author

asutosh commented Jun 27, 2022 •
edited

Please don't approve or merge this PR!!
This is made as part of testing generate releng command from gromit policy.

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jun 27, 2022

API tests result: success ✅
Branch used: refs/pull/4157/merge
Commit:
Triggered by: pull_request (@asutosh)
Execution page

@asutosh asutosh mentioned this pull request Jun 27, 2022
Merged
@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jun 27, 2022

API tests result: success ✅
Branch used: refs/pull/4157/merge
Commit: 13bb819
Triggered by: pull_request (@asutosh)
Execution page

titpetric
titpetric previously requested changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@titpetric titpetric left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would cause a regression in Dockerfile.std, as it is now. You could leave the commit in a Draft mode, so it's not mergeable.

@asutosh asutosh marked this pull request as draft June 27, 2022 11:59
@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 4, 2022

API tests result: failure 🚫
Branch used: refs/pull/4157/merge
Commit: c543477
Triggered by: pull_request (@asutosh)
Execution page

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 4, 2022

API tests result: failure 🚫
Branch used: refs/pull/4157/merge
Commit: 96d63c8
Triggered by: pull_request (@asutosh)
Execution page

1 similar comment
@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 4, 2022

API tests result: failure 🚫
Branch used: refs/pull/4157/merge
Commit: 96d63c8
Triggered by: pull_request (@asutosh)
Execution page

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 5, 2022

API tests result: failure 🚫
Branch used: refs/pull/4157/merge
Commit: 84fc671
Triggered by: pull_request (@asutosh)
Execution page

@asutosh asutosh marked this pull request as ready for review July 5, 2022 08:39
@asutosh
Copy link
Contributor Author

asutosh commented Jul 5, 2022

This would cause a regression in Dockerfile.std, as it is now. You could leave the commit in a Draft mode, so it's not mergeable.

Have made the necessary changes in Dockerfile.std parent templates, so that it aligns with the latest changes. There are some minor changes though, to make it work across other repos using the same template.

@asutosh asutosh requested a review from titpetric July 5, 2022 09:21
@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 6, 2022

API tests result: failure 🚫
Branch used: refs/pull/4157/merge
Commit: d237e02
Triggered by: pull_request (@asutosh)
Execution page

ermirizio
ermirizio reviewed Jul 6, 2022
View reviewed changes
Copy link
Contributor

@ermirizio ermirizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asutosh This looks fine for me so far, should I approve then?

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 7, 2022

API tests result: failure 🚫
Branch used: refs/pull/4157/merge
Commit: dca1e44
Triggered by: pull_request (@asutosh)
Execution page

alephnull
alephnull requested changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@alephnull alephnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions.

ci/goreleaser/goreleaser.yml Outdated Show resolved Hide resolved
ci/goreleaser/goreleaser.yml Show resolved Hide resolved
@asutosh asutosh requested a review from alephnull July 11, 2022 07:41
@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 11, 2022

API tests result: success ✅
Branch used: refs/pull/4157/merge
Commit: 11821fe
Triggered by: pull_request (@asutosh)
Execution page

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 11, 2022

API tests result: success ✅
Branch used: refs/pull/4157/merge
Commit: da639bb
Triggered by: pull_request (@asutosh)
Execution page

@asutosh asutosh changed the title Sync releng templates. [TD-918]: Sync releng templates. Jul 14, 2022
Gromit and others added 2 commits July 18, 2022 11:54
@asutosh
Sync releng templates.
4291ef7
@asutosh
Fix plugin compiler smoke test.
c8b0453 
Fix the plugin path being different from the test
apidef.json
@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 18, 2022

API tests result: success ✅
Branch used: refs/pull/4157/merge
Commit: d201206
Triggered by: pull_request (@asutosh)
Execution page

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 18, 2022

API tests result: success ✅
Branch used: refs/pull/4157/merge
Commit: c8b0453
Triggered by: pull_request (@asutosh)
Execution page

alephnull
alephnull approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@alephnull alephnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this to master and see how it goes.

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 25, 2022

API tests result: success ✅
Branch used: refs/pull/4157/merge
Commit: 44e67d2
Triggered by: pull_request (@alephnull)
Execution page

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 27, 2022

API tests result: success ✅
Branch used: refs/pull/4157/merge
Commit: 74cc8e5
Triggered by: pull_request (@asutosh)
Execution page

titpetric
titpetric reviewed Jul 27, 2022
View reviewed changes
ci/Dockerfile.std Show resolved Hide resolved
ci/goreleaser/goreleaser-el7.yml Show resolved Hide resolved
ci/goreleaser/goreleaser-el7.yml Show resolved Hide resolved
ci/aws/byol.pkr.hcl Show resolved Hide resolved
ci/goreleaser/goreleaser.yml Show resolved Hide resolved
ci/tests/plugin-compiler/docker-compose.yml Show resolved Hide resolved
@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 29, 2022

API tests result: success ✅
Branch used: refs/pull/4157/merge
Commit: cb32193
Triggered by: pull_request (@asutosh)
Execution page

@asutosh asutosh requested a review from titpetric July 29, 2022 11:40
@asutosh asutosh dismissed titpetric’s stale review August 3, 2022 11:40

Change requests are addressed.

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Aug 3, 2022

API tests result: success ✅
Branch used: refs/pull/4157/merge
Commit: 5e3d180
Triggered by: pull_request (@asutosh)
Execution page

@asutosh asutosh merged commit 4159340 into master Aug 3, 2022
@asutosh asutosh deleted the sync/releng branch August 3, 2022 12:52
@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Aug 3, 2022 •
edited by jira bot

API tests result: success ✅
Branch used: refs/heads/master
Commit: 4159340 TD-918: Sync releng templates. (#4157)

  • Sync releng templates.

  • Fix plugin compiler smoke test.

  • remove slim images and static binaries.

Fix the plugin path being different from the test
apidef.json

Co-authored-by: Gromit policy@gromit
Co-authored-by: Alok G Singh alok@tyk.io
Triggered by: push (@asutosh)
Execution page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alephnull alephnull alephnull approved these changes

@ermirizio ermirizio ermirizio approved these changes

@titpetric titpetric Awaiting requested review from titpetric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@asutosh @Tyk-ITS @titpetric @alephnull @ermirizio