From 04c70605474feb90fe77a62119cfb86e9a1d65f4 Mon Sep 17 00:00:00 2001 From: yousefed Date: Mon, 6 May 2024 08:49:19 +0200 Subject: [PATCH] fix: fix light / dark theme switching --- packages/react/src/editor/BlockNoteView.tsx | 26 +++------------------ 1 file changed, 3 insertions(+), 23 deletions(-) diff --git a/packages/react/src/editor/BlockNoteView.tsx b/packages/react/src/editor/BlockNoteView.tsx index 7813faab3..48c743de0 100644 --- a/packages/react/src/editor/BlockNoteView.tsx +++ b/packages/react/src/editor/BlockNoteView.tsx @@ -11,7 +11,6 @@ import React, { HTMLAttributes, ReactNode, Ref, - useCallback, useEffect, useMemo, useState, @@ -19,7 +18,6 @@ import React, { import usePrefersColorScheme from "use-prefers-color-scheme"; import { useEditorChange } from "../hooks/useEditorChange"; import { useEditorSelectionChange } from "../hooks/useEditorSelectionChange"; -import { mergeRefs } from "../util/mergeRefs"; import { BlockNoteContext, useBlockNoteContext } from "./BlockNoteContext"; import { BlockNoteDefaultUI, @@ -93,22 +91,8 @@ function BlockNoteViewComponent< const defaultColorScheme = existingContext?.colorSchemePreference || systemColorScheme; - const [editorColorScheme, setEditorColorScheme] = useState< - "light" | "dark" | undefined - >(undefined); - - const containerRef = useCallback( - (node: HTMLDivElement | null) => { - if (!node) { - return; - } - - setEditorColorScheme( - theme || defaultColorScheme === "dark" ? "dark" : "light" - ); - }, - [defaultColorScheme, theme] - ); + const editorColorScheme = + theme || (defaultColorScheme === "dark" ? "dark" : "light"); useEditorChange(onChange || emptyFn, editor); useEditorSelectionChange(onSelectionChange || emptyFn, editor); @@ -149,10 +133,6 @@ function BlockNoteViewComponent< }; }, [existingContext, editor]); - const refs = useMemo(() => { - return mergeRefs([containerRef, ref]); - }, [containerRef, ref]); - return ( @@ -164,7 +144,7 @@ function BlockNoteViewComponent< )} data-color-scheme={editorColorScheme} {...rest} - ref={refs}> + ref={ref}>