From 20fc32df91e01c4ab61be746a16ebc8afe3618bf Mon Sep 17 00:00:00 2001 From: yousefed Date: Fri, 1 May 2026 07:38:18 +0200 Subject: [PATCH] fix: guard hideMenuIfNotFrozen against undefined view state (#2694) When the EditorView is re-created (e.g. toggling editable) while the side menu is visible, a queued floating-ui scroll callback can fire after view.state has been cleared, causing a TypeError. Use optional chaining so the early return covers that case. Co-Authored-By: Claude Opus 4.7 (1M context) --- packages/core/src/extensions/SideMenu/SideMenu.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/src/extensions/SideMenu/SideMenu.ts b/packages/core/src/extensions/SideMenu/SideMenu.ts index 635929a756..e98059b585 100644 --- a/packages/core/src/extensions/SideMenu/SideMenu.ts +++ b/packages/core/src/extensions/SideMenu/SideMenu.ts @@ -785,8 +785,8 @@ export const SideMenuExtension = createExtension(({ editor }) => { * interfering with open submenus. */ hideMenuIfNotFrozen() { - if (!view!.menuFrozen && view!.state!.show) { - view!.state!.show = false; + if (!view!.menuFrozen && view!.state?.show) { + view!.state.show = false; view!.emitUpdate(view!.state!); } },