Import pinkiepromise.d.ts #682

Closed
basarat opened this Issue Oct 22, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@basarat
Member

basarat commented Oct 22, 2015

To overcome tsconfig compile issue. (if you F6 the whole atom-typescript project you will see what I mean quite easily)

@blakeembrey

This comment has been minimized.

Show comment
Hide comment
@blakeembrey

blakeembrey Nov 22, 2015

Member

This is actually easy to fix with typings now 👍 Just typings install npm:tsconfig -n tsconfig -S (though a little verbose).

Member

blakeembrey commented Nov 22, 2015

This is actually easy to fix with typings now 👍 Just typings install npm:tsconfig -n tsconfig -S (though a little verbose).

@basarat basarat removed the up-for-grabs label Nov 23, 2015

@basarat

This comment has been minimized.

Show comment
Hide comment
@basarat

basarat Nov 23, 2015

Member

@blakeembrey I actually got around it by just doing declare module 'pinkie-promise' locally :

declare module 'pinkie-promise'{
export = Promise;
}

I have a seperate issue that I would love your input on, npm run test (just ntsc -p ./lib) succeeds locally but fails on travis : https://travis-ci.org/TypeStrong/atom-typescript I hear it has something to do with new npm flatdir : #733 (comment) I don't get it :) 🌹

Member

basarat commented Nov 23, 2015

@blakeembrey I actually got around it by just doing declare module 'pinkie-promise' locally :

declare module 'pinkie-promise'{
export = Promise;
}

I have a seperate issue that I would love your input on, npm run test (just ntsc -p ./lib) succeeds locally but fails on travis : https://travis-ci.org/TypeStrong/atom-typescript I hear it has something to do with new npm flatdir : #733 (comment) I don't get it :) 🌹

@basarat basarat closed this Nov 23, 2015

@blakeembrey

This comment has been minimized.

Show comment
Hide comment
@blakeembrey

blakeembrey Nov 23, 2015

Member

Let me fix tsconfig here, I had to remove the typings field in package.json as it implied TypeScript could use it to resolve (which clearly was not the case, hence this issue). I can open a PR to use typings, if that makes sense.

Member

blakeembrey commented Nov 23, 2015

Let me fix tsconfig here, I had to remove the typings field in package.json as it implied TypeScript could use it to resolve (which clearly was not the case, hence this issue). I can open a PR to use typings, if that makes sense.

@basarat

This comment has been minimized.

Show comment
Hide comment
@basarat

basarat Nov 23, 2015

Member

I can open a PR to use typings, if that makes sense.

Sure ... PS: no hurry, love every bit of your effort 🌹

Member

basarat commented Nov 23, 2015

I can open a PR to use typings, if that makes sense.

Sure ... PS: no hurry, love every bit of your effort 🌹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment