Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import pinkiepromise.d.ts #682

Closed
basarat opened this issue Oct 22, 2015 · 4 comments
Closed

Import pinkiepromise.d.ts #682

basarat opened this issue Oct 22, 2015 · 4 comments
Labels
bug

Comments

@basarat
Copy link
Member

@basarat basarat commented Oct 22, 2015

To overcome tsconfig compile issue. (if you F6 the whole atom-typescript project you will see what I mean quite easily)

@blakeembrey
Copy link
Member

@blakeembrey blakeembrey commented Nov 22, 2015

This is actually easy to fix with typings now 👍 Just typings install npm:tsconfig -n tsconfig -S (though a little verbose).

@basarat basarat removed the up-for-grabs label Nov 23, 2015
@basarat
Copy link
Member Author

@basarat basarat commented Nov 23, 2015

@blakeembrey I actually got around it by just doing declare module 'pinkie-promise' locally :

declare module 'pinkie-promise'{
export = Promise;
}

I have a seperate issue that I would love your input on, npm run test (just ntsc -p ./lib) succeeds locally but fails on travis : https://travis-ci.org/TypeStrong/atom-typescript I hear it has something to do with new npm flatdir : #733 (comment) I don't get it :) 🌹

@basarat basarat closed this Nov 23, 2015
@blakeembrey
Copy link
Member

@blakeembrey blakeembrey commented Nov 23, 2015

Let me fix tsconfig here, I had to remove the typings field in package.json as it implied TypeScript could use it to resolve (which clearly was not the case, hence this issue). I can open a PR to use typings, if that makes sense.

@basarat
Copy link
Member Author

@basarat basarat commented Nov 23, 2015

I can open a PR to use typings, if that makes sense.

Sure ... PS: no hurry, love every bit of your effort 🌹

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.