Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename input is unusably small #1496

Closed
wants to merge 3 commits into from

Conversation

@Xapphire13
Copy link

commented Mar 28, 2019

Before

Screen Shot 2019-03-28 at 4 44 33 PM

After

Screen Shot 2019-04-03 at 12 07 17 PM

Xapphire13 added 2 commits Mar 28, 2019

@Xapphire13 Xapphire13 changed the title fix: Rename inpit is unusably small fix: Rename input is unusably small Mar 30, 2019

@lierdakil

This comment has been minimized.

Copy link
Collaborator

commented Mar 31, 2019

Uh. It shouldn't look like this. Why does it look like this?

Generally the "rename variable... etc" text should be above the input box. At least this was the case with all Atom versions up to 1.34 (as far as I can recall)

Are you using some kind of custom theme? Did this change in a recent Atom release? What's going on here?

@lierdakil

This comment has been minimized.

Copy link
Collaborator

commented Mar 31, 2019

Tested with Atom 1.35.1. Everything behaves as it should:
rename variable dialog rendered as intended

It would appear something in your environment sets display: flex; flex-direction:row on the block css class. Pretty sure this is not Atom's default.

@Xapphire13

This comment has been minimized.

Copy link
Author

commented Apr 3, 2019

Interesting. Let me see if I can identify what is causing this, I dont use any custom themes, so it must be a bad package

@Xapphire13

This comment has been minimized.

Copy link
Author

commented Apr 3, 2019

I took a look and nothing is setting block to have flex-direction: row, in fact, nothing is setting the flex-direction style on it at all, so it's just defaulting to row.

Screen Shot 2019-04-03 at 11 56 45 AM

I could update my PR to include styling for this?

@Xapphire13

This comment has been minimized.

Copy link
Author

commented Apr 3, 2019

I have updated the PR with the styling required to get it looking exactly as you have it

@lierdakil

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

nothing is setting block to have flex-direction: row

Why does it have display: flex; though? Where does that come from? Atom's default is display: block (edit: well, actually, Atom's default is no display property explicitly set at all, and for divs the default value is block)

@Xapphire13

This comment has been minimized.

Copy link
Author

commented Apr 13, 2019

Does it not make sense to have the style explicitly set for the input, as to avoid being messed up by other extensions?

@lierdakil

This comment has been minimized.

Copy link
Collaborator

commented Apr 17, 2019

The point is we don't have any control over "other extensions", and themes might include arbitrary overrides which we don't want to mess up. So with CSS the general rule I think should be "less is more". If you figure out which particular extension is messing up your stylesheets here, then we can discuss this further to resolve this particular conflict.

FWIW, div.block is a default Atom thing, which is supposed to have display:block I think, so whatever messes up your stylesheet breaks more than Atom-TypeScript.

@Xapphire13 Xapphire13 closed this Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.