Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCustomTransformers error message fix #1334

merged 1 commit into from
Jun 6, 2021


Copy link

@blaky blaky commented Jun 3, 2021

The error message here was misleading, it wasn't reporting on the same variable that it checks in line 360. If ts-loader was configured with a getCustomTransformers function that returned a module path which didn't had a module.exports = function(){..} in it, the error message displayed was the following: ... should export a function, got function.

Copy link

Thanks - do you want to add an entry to the and increment the package.json?

@blaky blaky force-pushed the transformer-error-message-fix branch from ee57aa2 to e3f35ee Compare June 4, 2021 06:57
Copy link
Contributor Author

blaky commented Jun 4, 2021

@johnnyreilly version number and changelog updated

@johnnyreilly johnnyreilly merged commit 1cfb77c into TypeStrong:main Jun 6, 2021
Copy link

Shipping with - thanks!

@blaky blaky deleted the transformer-error-message-fix branch June 6, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants