Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined configPath now falls back to default #1346

merged 2 commits into from
Jul 24, 2021


Copy link

@johnnyreilly johnnyreilly commented Jul 24, 2021

Fixes #1345 by ensuring that configPath is set to the default value if undefined is supplied.

There's some prettier reformatting in this that makes the PR a little noisier - but this effectively comes down to a 2 line change.

@@ -289,6 +288,7 @@ function makeLoaderOptions(instanceName: string, loaderOptions: LoaderOptions) {
options.ignoreDiagnostics = arrify(options.ignoreDiagnostics).map(Number);
options.logLevel = options.logLevel.toUpperCase() as LogLevel;
options.instance = instanceName;
options.configFile = options.configFile || 'tsconfig.json';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line here (and the deletion of 270) is the essential fix

@johnnyreilly johnnyreilly merged commit 55d2a85 into main Jul 24, 2021
@johnnyreilly johnnyreilly deleted the bugfix/options_configfile branch July 24, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Allow options.configFile to be undefined
1 participant