Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 4 9 #1547

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Typescript 4 9 #1547

merged 3 commits into from
Nov 17, 2022

Conversation

johnnyreilly
Copy link
Member

No description provided.

@johnnyreilly johnnyreilly merged commit 620ee79 into main Nov 17, 2022
@johnnyreilly johnnyreilly deleted the typescript_4_9 branch November 17, 2022 09:03
@HaimCandiTech
Copy link

@johnnyreilly
Is there a chance this somehow got into the published version?

We got an error on our vue app:

  • "Uncaught TypeError: Cannot assign to read only property 'exports' of object '#'

    Looking around, we found that the vue build is warning us that Typescript version 4.9.3 is not supported
    We tried to specify the typescript version in the package.json but it didn't help
    Looking at the package-locks.json we found out that ts-loader uses Typescript 4.9.3
    We had to find an old package-lock.json file in order to control it

    Where does it specify the exact version of typescript that ts-loader uses?

@johnnyreilly
Copy link
Member Author

johnnyreilly commented Nov 20, 2022

ts-loader uses "*" - there shouldn't be any dependency on a specific version forced through ts-loader itself. What's more, we haven't published a new version and so you shouldn't be picking that up from us

"typescript": "*",

@HaimCandiTech
Copy link

You are super right
It was wrong for me to assume that
Just some weird warning regarding ts

Some other package were to blame
Sorry for wasting your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants