Adding an option to suppress log messages. #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrantly
added a commit
that referenced
this pull request
Jun 25, 2015
Adding an option to suppress log messages.
Member
|
Good idea! I'm going to merge but I'll make a couple tweaks before publishing (a |
Author
|
Awesome, thanks! |
Member
|
Published as v0.4.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project, I run
webpackfrom the shell, and expect its output to be valid json. Having this module log to the console breaks the json parsing. In another context, I am spawning a process that where running this causes a console log that breaks the TAP output. In both cases, I would like the ability to turn off the logging.I thought about adding a test but it seems like it would be quite a bit of work, and I'm not sure it's a good ROI.
Thanks for making this module!