Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The big refactor #343

Merged
merged 23 commits into from Nov 1, 2016

Conversation

Projects
None yet
1 participant
@johnnyreilly
Copy link
Member

commented Oct 26, 2016

No description provided.

johnnyreilly added some commits Oct 26, 2016

@johnnyreilly

This comment has been minimized.

Copy link
Member Author

commented Oct 29, 2016

Hey @jbrantly, Re: #335

I think I've reached the end of my initial refactor. Despite initial appearances, it's pretty much the code as was (right down to the comments; all intact). It's just been split out into a bunch of modules and hopefully that aids comprehension (it helps mine).

It's written using TS 2.0 and all the tests are passing.

My plan is to merge this and use this as the new base for ts-loader 1.x. I'd ship a beta of this initially just to make sure there's no undiscovered gremlins in my changes and then, all being well, look to ship 1.0 proper.

Before all that begins I wanted to give you the chance to express a view on the refactor; any problems / preferences from your point of view?

johnnyreilly added some commits Oct 29, 2016

@johnnyreilly johnnyreilly changed the title Started refactor again The big refactor Oct 30, 2016

@johnnyreilly

This comment has been minimized.

Copy link
Member Author

commented Oct 30, 2016

This has now been published to npm as 1.0.0-beta-1. If anyone wants to give it a whirl it should just work ™️

@johnnyreilly

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2016

I'm presently testing this on projects of my own. All good so far. Will look to merge / release later this week if all still good.

johnnyreilly added some commits Oct 31, 2016

improve interfaces
optimise formatErrors
Fix test data for errors test

@johnnyreilly johnnyreilly merged commit 66d02a8 into TypeStrong:master Nov 1, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.