Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Changes for webpack 4 #710

Merged
merged 76 commits into from Feb 22, 2018

Conversation

Projects
None yet
2 participants
@johnnyreilly
Copy link
Member

johnnyreilly commented Jan 14, 2018

initial migration - tests mostly failing so far. Will seek advice

#709

@johnnyreilly

This comment has been minimized.

Copy link
Member Author

johnnyreilly commented Jan 25, 2018

Things to do:

Where to get startTime from?

johnnyreilly added some commits Jan 30, 2018

@ekulabuhov

This comment has been minimized.

Copy link

ekulabuhov commented Feb 15, 2018

Hi! Thanks for the awesome work you're doing! I've tried to run your branch with webpack 4.0.0-beta.1.
It's a very simple clean slate project with a single file entry point "index.ts". And I'm getting this error:

https://gist.github.com/ekulabuhov/1f0a289a8e62fffd044759f31510f77b

Here's the example project: https://github.com/ekulabuhov/webpack4-test

Any clues on what's going on?

@johnnyreilly

This comment has been minimized.

Copy link
Member Author

johnnyreilly commented Feb 15, 2018

Hi @ekulabuhov

I think you need to specify the ts-loader beta dependency differently. Check out this blog post:

https://blog.johnnyreilly.com/2018/01/webpack-4-ts-loader-fork-ts-checker.html?

@ekulabuhov

This comment has been minimized.

Copy link

ekulabuhov commented Feb 15, 2018

Thanks @johnnyreilly ! That helped!

johnnyreilly added some commits Feb 15, 2018

@johnnyreilly

This comment has been minimized.

Copy link
Member Author

johnnyreilly commented Feb 22, 2018

I'm going to merge this in preparation for the webpack 4 release. I've created a ts-loader-3 branch in case there's a need for further ts-loader / webpack 3 work. But the expectation is it's webpack 4 from now on.

@johnnyreilly johnnyreilly merged commit 388f2a6 into TypeStrong:master Feb 22, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.