Skip to content

Update all bundled node sources to latest node v18 versions; use process.binding('fs') for performance #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cspotcode opened this issue May 17, 2022 · 0 comments

Comments

@cspotcode
Copy link
Collaborator

cspotcode commented May 17, 2022

Take a pass over all the bundled nodejs sources. Pull down a recent v18 revision and see about updating them all to that version.

Our test coverage is pretty good so we should catch any mistakes. And I've beefed up the diffing conveniences to make it easier to merge our changes / node's changes.

For more performant filesystem access, consider:

  • use process.binding('fs') for more performant stat and package.json reading
  • use fs.statSync('', {throwIfNoEntry: false}) to avoid creating garbage

Should sync our error construction logic with node's
https://github.com/nodejs/node/blob/06dd8c31fd7e736f1d0e57d8ae4a41227661bbc3/lib/internal/errors.js#L347-L381

@cspotcode cspotcode added this to the 10.8.0 milestone May 18, 2022
@cspotcode cspotcode changed the title Update all bundled node sources to latest node v18 versions Update all bundled node sources to latest node v18 versions; use process.binding('fs') for performance May 18, 2022
@cspotcode cspotcode modified the milestones: 10.8.0, 10.9.0 or 11.0.0 May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant